Show suggested follows on search screen in mobile layout (#9010)
Reminder: Suggestions were added in #7918 and are based on who you interact with who you do not follow. E.g. if you boost someone a lot from seeing other people's boosts of that person, it makes sense you might be interested in following the original source; or if you reply to someone a lot, maybe you'd want to follow them Each suggestion can be dismissed
This commit is contained in:
parent
969a10a5d1
commit
ad510db3a1
52
app/javascript/mastodon/actions/suggestions.js
Normal file
52
app/javascript/mastodon/actions/suggestions.js
Normal file
@ -0,0 +1,52 @@
|
|||||||
|
import api from '../api';
|
||||||
|
import { importFetchedAccounts } from './importer';
|
||||||
|
|
||||||
|
export const SUGGESTIONS_FETCH_REQUEST = 'SUGGESTIONS_FETCH_REQUEST';
|
||||||
|
export const SUGGESTIONS_FETCH_SUCCESS = 'SUGGESTIONS_FETCH_SUCCESS';
|
||||||
|
export const SUGGESTIONS_FETCH_FAIL = 'SUGGESTIONS_FETCH_FAIL';
|
||||||
|
|
||||||
|
export const SUGGESTIONS_DISMISS = 'SUGGESTIONS_DISMISS';
|
||||||
|
|
||||||
|
export function fetchSuggestions() {
|
||||||
|
return (dispatch, getState) => {
|
||||||
|
dispatch(fetchSuggestionsRequest());
|
||||||
|
|
||||||
|
api(getState).get('/api/v1/suggestions').then(response => {
|
||||||
|
dispatch(importFetchedAccounts(response.data));
|
||||||
|
dispatch(fetchSuggestionsSuccess(response.data));
|
||||||
|
}).catch(error => dispatch(fetchSuggestionsFail(error)));
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
|
export function fetchSuggestionsRequest() {
|
||||||
|
return {
|
||||||
|
type: SUGGESTIONS_FETCH_REQUEST,
|
||||||
|
skipLoading: true,
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
|
export function fetchSuggestionsSuccess(accounts) {
|
||||||
|
return {
|
||||||
|
type: SUGGESTIONS_FETCH_SUCCESS,
|
||||||
|
accounts,
|
||||||
|
skipLoading: true,
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
|
export function fetchSuggestionsFail(error) {
|
||||||
|
return {
|
||||||
|
type: SUGGESTIONS_FETCH_FAIL,
|
||||||
|
error,
|
||||||
|
skipLoading: true,
|
||||||
|
skipAlert: true,
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
|
export const dismissSuggestion = accountId => (dispatch, getState) => {
|
||||||
|
dispatch({
|
||||||
|
type: SUGGESTIONS_DISMISS,
|
||||||
|
id: accountId,
|
||||||
|
});
|
||||||
|
|
||||||
|
api(getState).delete(`/api/v1/suggestions/${accountId}`);
|
||||||
|
};
|
@ -30,6 +30,9 @@ class Account extends ImmutablePureComponent {
|
|||||||
onMuteNotifications: PropTypes.func.isRequired,
|
onMuteNotifications: PropTypes.func.isRequired,
|
||||||
intl: PropTypes.object.isRequired,
|
intl: PropTypes.object.isRequired,
|
||||||
hidden: PropTypes.bool,
|
hidden: PropTypes.bool,
|
||||||
|
actionIcon: PropTypes.string,
|
||||||
|
actionTitle: PropTypes.string,
|
||||||
|
onActionClick: PropTypes.func,
|
||||||
};
|
};
|
||||||
|
|
||||||
handleFollow = () => {
|
handleFollow = () => {
|
||||||
@ -52,8 +55,12 @@ class Account extends ImmutablePureComponent {
|
|||||||
this.props.onMuteNotifications(this.props.account, false);
|
this.props.onMuteNotifications(this.props.account, false);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
handleAction = () => {
|
||||||
|
this.props.onActionClick(this.props.account);
|
||||||
|
}
|
||||||
|
|
||||||
render () {
|
render () {
|
||||||
const { account, intl, hidden } = this.props;
|
const { account, intl, hidden, onActionClick, actionIcon, actionTitle } = this.props;
|
||||||
|
|
||||||
if (!account) {
|
if (!account) {
|
||||||
return <div />;
|
return <div />;
|
||||||
@ -70,7 +77,9 @@ class Account extends ImmutablePureComponent {
|
|||||||
|
|
||||||
let buttons;
|
let buttons;
|
||||||
|
|
||||||
if (account.get('id') !== me && account.get('relationship', null) !== null) {
|
if (onActionClick && actionIcon) {
|
||||||
|
buttons = <IconButton icon={actionIcon} title={actionTitle} onClick={this.handleAction} />;
|
||||||
|
} else if (account.get('id') !== me && account.get('relationship', null) !== null) {
|
||||||
const following = account.getIn(['relationship', 'following']);
|
const following = account.getIn(['relationship', 'following']);
|
||||||
const requested = account.getIn(['relationship', 'requested']);
|
const requested = account.getIn(['relationship', 'requested']);
|
||||||
const blocking = account.getIn(['relationship', 'blocking']);
|
const blocking = account.getIn(['relationship', 'blocking']);
|
||||||
|
@ -1,19 +1,56 @@
|
|||||||
import React from 'react';
|
import React from 'react';
|
||||||
|
import PropTypes from 'prop-types';
|
||||||
import ImmutablePropTypes from 'react-immutable-proptypes';
|
import ImmutablePropTypes from 'react-immutable-proptypes';
|
||||||
import { FormattedMessage } from 'react-intl';
|
import { FormattedMessage, defineMessages, injectIntl } from 'react-intl';
|
||||||
import AccountContainer from '../../../containers/account_container';
|
import AccountContainer from '../../../containers/account_container';
|
||||||
import StatusContainer from '../../../containers/status_container';
|
import StatusContainer from '../../../containers/status_container';
|
||||||
import ImmutablePureComponent from 'react-immutable-pure-component';
|
import ImmutablePureComponent from 'react-immutable-pure-component';
|
||||||
import Hashtag from '../../../components/hashtag';
|
import Hashtag from '../../../components/hashtag';
|
||||||
|
|
||||||
export default class SearchResults extends ImmutablePureComponent {
|
const messages = defineMessages({
|
||||||
|
dismissSuggestion: { id: 'suggestions.dismiss', defaultMessage: 'Dismiss suggestion' },
|
||||||
|
});
|
||||||
|
|
||||||
|
export default @injectIntl
|
||||||
|
class SearchResults extends ImmutablePureComponent {
|
||||||
|
|
||||||
static propTypes = {
|
static propTypes = {
|
||||||
results: ImmutablePropTypes.map.isRequired,
|
results: ImmutablePropTypes.map.isRequired,
|
||||||
|
suggestions: ImmutablePropTypes.list.isRequired,
|
||||||
|
fetchSuggestions: PropTypes.func.isRequired,
|
||||||
|
dismissSuggestion: PropTypes.func.isRequired,
|
||||||
|
intl: PropTypes.object.isRequired,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
componentDidMount () {
|
||||||
|
this.props.fetchSuggestions();
|
||||||
|
}
|
||||||
|
|
||||||
render () {
|
render () {
|
||||||
const { results } = this.props;
|
const { intl, results, suggestions, dismissSuggestion } = this.props;
|
||||||
|
|
||||||
|
if (results.isEmpty() && !suggestions.isEmpty()) {
|
||||||
|
return (
|
||||||
|
<div className='search-results'>
|
||||||
|
<div className='trends'>
|
||||||
|
<div className='trends__header'>
|
||||||
|
<i className='fa fa-user-plus fa-fw' />
|
||||||
|
<FormattedMessage id='suggestions.header' defaultMessage='You might be interested in…' />
|
||||||
|
</div>
|
||||||
|
|
||||||
|
{suggestions && suggestions.map(accountId => (
|
||||||
|
<AccountContainer
|
||||||
|
key={accountId}
|
||||||
|
id={accountId}
|
||||||
|
actionIcon='times'
|
||||||
|
actionTitle={intl.formatMessage(messages.dismissSuggestion)}
|
||||||
|
onActionClick={dismissSuggestion}
|
||||||
|
/>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
let accounts, statuses, hashtags;
|
let accounts, statuses, hashtags;
|
||||||
let count = 0;
|
let count = 0;
|
||||||
|
@ -1,8 +1,15 @@
|
|||||||
import { connect } from 'react-redux';
|
import { connect } from 'react-redux';
|
||||||
import SearchResults from '../components/search_results';
|
import SearchResults from '../components/search_results';
|
||||||
|
import { fetchSuggestions, dismissSuggestion } from '../../../actions/suggestions';
|
||||||
|
|
||||||
const mapStateToProps = state => ({
|
const mapStateToProps = state => ({
|
||||||
results: state.getIn(['search', 'results']),
|
results: state.getIn(['search', 'results']),
|
||||||
|
suggestions: state.getIn(['suggestions', 'items']),
|
||||||
});
|
});
|
||||||
|
|
||||||
export default connect(mapStateToProps)(SearchResults);
|
const mapDispatchToProps = dispatch => ({
|
||||||
|
fetchSuggestions: () => dispatch(fetchSuggestions()),
|
||||||
|
dismissSuggestion: account => dispatch(dismissSuggestion(account.get('id'))),
|
||||||
|
});
|
||||||
|
|
||||||
|
export default connect(mapStateToProps, mapDispatchToProps)(SearchResults);
|
||||||
|
@ -28,6 +28,7 @@ import lists from './lists';
|
|||||||
import listEditor from './list_editor';
|
import listEditor from './list_editor';
|
||||||
import filters from './filters';
|
import filters from './filters';
|
||||||
import conversations from './conversations';
|
import conversations from './conversations';
|
||||||
|
import suggestions from './suggestions';
|
||||||
|
|
||||||
const reducers = {
|
const reducers = {
|
||||||
dropdown_menu,
|
dropdown_menu,
|
||||||
@ -59,6 +60,7 @@ const reducers = {
|
|||||||
listEditor,
|
listEditor,
|
||||||
filters,
|
filters,
|
||||||
conversations,
|
conversations,
|
||||||
|
suggestions,
|
||||||
};
|
};
|
||||||
|
|
||||||
export default combineReducers(reducers);
|
export default combineReducers(reducers);
|
||||||
|
30
app/javascript/mastodon/reducers/suggestions.js
Normal file
30
app/javascript/mastodon/reducers/suggestions.js
Normal file
@ -0,0 +1,30 @@
|
|||||||
|
import {
|
||||||
|
SUGGESTIONS_FETCH_REQUEST,
|
||||||
|
SUGGESTIONS_FETCH_SUCCESS,
|
||||||
|
SUGGESTIONS_FETCH_FAIL,
|
||||||
|
SUGGESTIONS_DISMISS,
|
||||||
|
} from '../actions/suggestions';
|
||||||
|
import { Map as ImmutableMap, List as ImmutableList, fromJS } from 'immutable';
|
||||||
|
|
||||||
|
const initialState = ImmutableMap({
|
||||||
|
items: ImmutableList(),
|
||||||
|
isLoading: false,
|
||||||
|
});
|
||||||
|
|
||||||
|
export default function suggestionsReducer(state = initialState, action) {
|
||||||
|
switch(action.type) {
|
||||||
|
case SUGGESTIONS_FETCH_REQUEST:
|
||||||
|
return state.set('isLoading', true);
|
||||||
|
case SUGGESTIONS_FETCH_SUCCESS:
|
||||||
|
return state.withMutations(map => {
|
||||||
|
map.set('items', fromJS(action.accounts.map(x => x.id)));
|
||||||
|
map.set('isLoading', false);
|
||||||
|
});
|
||||||
|
case SUGGESTIONS_FETCH_FAIL:
|
||||||
|
return state.set('isLoading', false);
|
||||||
|
case SUGGESTIONS_DISMISS:
|
||||||
|
return state.update('items', list => list.filterNot(id => id === action.id));
|
||||||
|
default:
|
||||||
|
return state;
|
||||||
|
}
|
||||||
|
};
|
Loading…
Reference in New Issue
Block a user