Fix error when trying to update counters for statuses that are gone (#8251)

2018-08-18 03:03:23 +02:00
parent 78fa926ed5
commit d010816ba8
3 changed files with 29 additions and 6 deletions
--- a/app/models/favourite.rb
+++ b/app/models/favourite.rb
@ -32,11 +32,11 @@ class Favourite < ApplicationRecord
  private

  def increment_cache_counters
-    status.increment_count!(:favourites_count)
+    status&.increment_count!(:favourites_count)
  end

  def decrement_cache_counters
    return if association(:status).loaded? && (status.marked_for_destruction? || status.marked_for_mass_destruction?)
-    status.decrement_count!(:favourites_count)
+    status&.decrement_count!(:favourites_count)
  end
 end