* Do not misattribute inlined boosts if `attributedTo` isn't present Fixes #10950 * Fix tests
		
			
				
	
	
		
			161 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			161 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| require 'rails_helper'
 | |
| 
 | |
| RSpec.describe ActivityPub::Activity::Announce do
 | |
|   let(:sender)    { Fabricate(:account, followers_url: 'http://example.com/followers', uri: 'https://example.com/actor') }
 | |
|   let(:recipient) { Fabricate(:account) }
 | |
|   let(:status)    { Fabricate(:status, account: recipient) }
 | |
| 
 | |
|   let(:json) do
 | |
|     {
 | |
|       '@context': 'https://www.w3.org/ns/activitystreams',
 | |
|       id: 'foo',
 | |
|       type: 'Announce',
 | |
|       actor: 'https://example.com/actor',
 | |
|       object: object_json,
 | |
|       to: 'http://example.com/followers',
 | |
|     }.with_indifferent_access
 | |
|   end
 | |
| 
 | |
|   let(:unknown_object_json) do
 | |
|     {
 | |
|       '@context': 'https://www.w3.org/ns/activitystreams',
 | |
|       id: 'https://example.com/actor/hello-world',
 | |
|       type: 'Note',
 | |
|       attributedTo: 'https://example.com/actor',
 | |
|       content: 'Hello world',
 | |
|       to: 'http://example.com/followers',
 | |
|     }
 | |
|   end
 | |
| 
 | |
|   subject { described_class.new(json, sender) }
 | |
| 
 | |
|   describe '#perform' do
 | |
|     context 'when sender is followed by a local account' do
 | |
|       before do
 | |
|         Fabricate(:account).follow!(sender)
 | |
|         stub_request(:get, 'https://example.com/actor/hello-world').to_return(body: Oj.dump(unknown_object_json))
 | |
|         subject.perform
 | |
|       end
 | |
| 
 | |
|       context 'a known status' do
 | |
|         let(:object_json) do
 | |
|           ActivityPub::TagManager.instance.uri_for(status)
 | |
|         end
 | |
| 
 | |
|         it 'creates a reblog by sender of status' do
 | |
|           expect(sender.reblogged?(status)).to be true
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'an unknown status' do
 | |
|         let(:object_json) { 'https://example.com/actor/hello-world' }
 | |
| 
 | |
|         it 'creates a reblog by sender of status' do
 | |
|           reblog = sender.statuses.first
 | |
| 
 | |
|           expect(reblog).to_not be_nil
 | |
|           expect(reblog.reblog.text).to eq 'Hello world'
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'self-boost of a previously unknown status with correct attributedTo' do
 | |
|         let(:object_json) do
 | |
|           {
 | |
|             id: 'https://example.com/actor#bar',
 | |
|             type: 'Note',
 | |
|             content: 'Lorem ipsum',
 | |
|             attributedTo: 'https://example.com/actor',
 | |
|             to: 'http://example.com/followers',
 | |
|           }
 | |
|         end
 | |
| 
 | |
|         it 'creates a reblog by sender of status' do
 | |
|           expect(sender.reblogged?(sender.statuses.first)).to be true
 | |
|         end
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     context 'when the status belongs to a local user' do
 | |
|       before do
 | |
|         subject.perform
 | |
|       end
 | |
| 
 | |
|       let(:object_json) do
 | |
|         ActivityPub::TagManager.instance.uri_for(status)
 | |
|       end
 | |
| 
 | |
|       it 'creates a reblog by sender of status' do
 | |
|         expect(sender.reblogged?(status)).to be true
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     context 'when the sender is relayed' do
 | |
|       let!(:relay_account) { Fabricate(:account, inbox_url: 'https://relay.example.com/inbox') }
 | |
|       let!(:relay) { Fabricate(:relay, inbox_url: 'https://relay.example.com/inbox') }
 | |
| 
 | |
|       subject { described_class.new(json, sender, relayed_through_account: relay_account) }
 | |
| 
 | |
|       context 'and the relay is enabled' do
 | |
|         before do
 | |
|           relay.update(state: :accepted)
 | |
|           subject.perform
 | |
|         end
 | |
| 
 | |
|         let(:object_json) do
 | |
|           {
 | |
|             id: 'https://example.com/actor#bar',
 | |
|             type: 'Note',
 | |
|             content: 'Lorem ipsum',
 | |
|             to: 'http://example.com/followers',
 | |
|             attributedTo: 'https://example.com/actor',
 | |
|           }
 | |
|         end
 | |
| 
 | |
|         it 'creates a reblog by sender of status' do
 | |
|           expect(sender.statuses.count).to eq 2
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'and the relay is disabled' do
 | |
|         before do
 | |
|           subject.perform
 | |
|         end
 | |
| 
 | |
|         let(:object_json) do
 | |
|           {
 | |
|             id: 'https://example.com/actor#bar',
 | |
|             type: 'Note',
 | |
|             content: 'Lorem ipsum',
 | |
|             to: 'http://example.com/followers',
 | |
|             attributedTo: 'https://example.com/actor',
 | |
|           }
 | |
|         end
 | |
| 
 | |
|         it 'does not create anything' do
 | |
|           expect(sender.statuses.count).to eq 0
 | |
|         end
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     context 'when the sender has no relevance to local activity' do
 | |
|       before do
 | |
|         subject.perform
 | |
|       end
 | |
| 
 | |
|       let(:object_json) do
 | |
|         {
 | |
|           id: 'https://example.com/actor#bar',
 | |
|           type: 'Note',
 | |
|           content: 'Lorem ipsum',
 | |
|           to: 'http://example.com/followers',
 | |
|           attributedTo: 'https://example.com/actor',
 | |
|         }
 | |
|       end
 | |
| 
 | |
|       it 'does not create anything' do
 | |
|         expect(sender.statuses.count).to eq 0
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| end
 |