hometown/app
Eugen Rochko 21ad21cb50
Improve signature verification safeguards (#8959)
* Downcase signed_headers string before building the signed string

The HTTP Signatures draft does not mandate the “headers” field to be downcased,
but mandates the header field names to be downcased in the signed string, which
means that prior to this patch, Mastodon could fail to process signatures from
some compliant clients. It also means that it would not actually check the
Digest of non-compliant clients that wouldn't use a lowercased Digest field
name.

Thankfully, I don't know of any such client.

* Revert "Remove dead code (#8919)"

This reverts commit a00ce8c92c.

* Restore time window checking, change it to 12 hours

By checking the Date header, we can prevent replaying old vulnerable
signatures. The focus is to prevent replaying old vulnerable requests
from software that has been fixed in the meantime, so a somewhat long
window should be fine and accounts for timezone misconfiguration.

* Escape users' URLs when formatting them

Fixes possible HTML injection

* Escape all string interpolations in Formatter class

Slightly improve performance by reducing class allocations
from repeated Formatter#encode calls

* Fix code style issues
2018-10-12 00:15:55 +02:00
..
chewy Get rid of Chewy order/limit warning (#8355) 2018-08-22 02:44:56 +02:00
controllers Improve signature verification safeguards (#8959) 2018-10-12 00:15:55 +02:00
helpers Add dns-prefetch if using different host for assets or uploads (#8942) 2018-10-10 01:31:10 +02:00
javascript Do not push DMs into the home feed (#8940) 2018-10-11 01:31:03 +02:00
lib Improve signature verification safeguards (#8959) 2018-10-12 00:15:55 +02:00
mailers Fix low-hanging rubocop gripes (#8458) 2018-08-26 19:22:46 +02:00
models rubocop issues - Cleaning up (#8912) 2018-10-08 04:50:11 +02:00
policies Allow mods to disable login, improve message when login disabled (#8329) 2018-08-23 23:26:29 +02:00
presenters Replace SVG asset with Custom mascot (#8766) 2018-10-08 00:20:45 +02:00
serializers Add conversations API (#8832) 2018-10-07 23:44:58 +02:00
services Do not push DMs into the home feed (#8940) 2018-10-11 01:31:03 +02:00
validators Limit the number of people that can be followed from one account (#8807) 2018-10-04 17:36:11 +02:00
views Add description meta tag additionally to og:description (#8941) 2018-10-10 02:21:30 +02:00
workers Track historical space stats in PgHero to determine PostgreSQL growth (#8906) 2018-10-09 19:35:14 +02:00