autonomic-cooperative/ojuso-map
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Get flake8 running OK

Browse Source
This commit is contained in:
Anna Sidwell 2019-08-19 23:52:27 +02:00
parent e3e3f6d5db
commit 73fe51ba9c
20 changed files with 93 additions and 109 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
apps/api/urls.py
View File

@ -1,13 +1,4 @@
from django.conf.urls import include, url
from django.urls import reverse
from django.conf.urls.i18n import i18n_patterns
from django.contrib import admin
from django.contrib.auth.models import User
from rest_framework import routers, serializers, viewsets
from rest_framework_gis import serializers as gis_serializers
from apps.files.models import File
from apps.map.models import CaseStudy, PointOfInterest
from rest_framework import routers
from . import views

6
apps/api/views.py
View File

@ -1,9 +1,5 @@
from django.conf.urls import include, url
from django.urls import reverse
from django.conf.urls.i18n import i18n_patterns
from django.contrib import admin
from django.contrib.auth.models import User
from rest_framework import routers, serializers, viewsets
from rest_framework import serializers, viewsets
from rest_framework_gis import serializers as gis_serializers
from apps.files.models import File

2
apps/contact/tests.py
View File

@ -1,3 +1,3 @@
from django.test import TestCase
# from django.test import TestCase
# Create your tests here.

2
apps/files/models.py
View File

@ -2,8 +2,6 @@ from django.contrib.auth.models import User
from django.db import models
from django.utils.translation import ugettext_lazy as _
from apps.map.models import CaseStudy, CaseStudyDraft
class BaseFile(models.Model):
file = models.FileField(upload_to=".")

2
apps/files/tests.py
View File

@ -47,7 +47,7 @@ class FileTests(TestCase):
self.assertRedirects(response, login_url)
def test_post_and_delete(self):
login = self.login()
self.login()
with open("apps/map/static/map/ojuso-logo-white.png", "rb") as fp:
response = self.client.post(reverse("files:upload_image"), {"file": fp})

1
apps/files/views.py
View File

@ -1,7 +1,6 @@
from django.core.exceptions import PermissionDenied
from django.contrib.auth.mixins import LoginRequiredMixin
from django.http import JsonResponse
from django.shortcuts import render
from django.views.generic import FormView, DetailView
from .forms import ImageFileForm, FileForm

7
apps/map/models.py
View File

@ -129,7 +129,8 @@ class CaseStudy(models.Model):
(
"FMO",
_(
"Nederlandse Financieringsmaatschappij voor Ontwikkelingslanden NV (Netherlands Development Finance Company, FMO)"
"Nederlandse Financieringsmaatschappij voor Ontwikkelingslanden NV"
" (Netherlands Development Finance Company, FMO)"
),
),
("NDB", _("New Development Bank (NDB) (formerly BRICS Development Bank)")),
@ -712,7 +713,7 @@ class CaseStudy(models.Model):
blank=True,
)
## Energy generation project
# -- Energy generation project --
generation_type = models.CharField(
verbose_name=_("What kind of energy is generated?"),
@ -917,7 +918,7 @@ class CaseStudy(models.Model):
blank=True,
)
## Manufacturing
# -- Manufacturing --
manufacturing_type = models.CharField(
verbose_name=_("Which of the following options best describes this case?"),

12
apps/map/tests.py
View File

@ -1,6 +1,7 @@
import pytest
from django.contrib.auth.models import User
from django.contrib.sessions.middleware import SessionMiddleware
from django.http import QueryDict
from django.http.response import Http404
from django.test import RequestFactory
from django.test import TestCase
from django.urls import reverse
@ -60,10 +61,9 @@ class CaseStudyDraftAPITests(TestCase):
def test_get_empty(self):
request = self.factory.get(self.url)
request.user = self.user
response = DraftsAPI.as_view()(request)
self.assertEqual(response.status_code, 404)
self.assertEqual(response.content, b"")
with pytest.raises(Http404):
DraftsAPI.as_view()(request)
def test_put_works(self):
contents = '{"test":1}'
@ -86,7 +86,7 @@ class CaseStudyDraftAPITests(TestCase):
self.assertEqual(response.content.decode(), draft.data)
def test_update(self):
draft = self.fake_draft()
self.fake_draft()
new_contents = '{"fnord": 7}'
request = self.factory.put(self.url, data=new_contents)
@ -100,7 +100,7 @@ class CaseStudyDraftAPITests(TestCase):
)
def test_delete(self):
draft = self.fake_draft()
self.fake_draft()
request = self.factory.delete(self.url)
request.user = self.user

2
apps/map/urls.py
View File

@ -2,9 +2,7 @@ from django.conf.urls import url
from django.urls import reverse_lazy
from django.views.generic import RedirectView
from django.views.i18n import JavaScriptCatalog
from djgeojson.views import GeoJSONLayerView
from .models import CaseStudy
from . import views
urlpatterns = [

2
apps/map/validators.py
View File

@ -20,4 +20,4 @@ class VimeoURLValidator(RegexValidator):
class YouTubeOrVimeoValidator(RegexValidator):
regex = r"https?:\/\/(player.|www.)?(vimeo\.com|youtu(be\.com|\.be))\/(video\/|embed\/|watch\?v=|v\/)?([A-Za-z0-9]{1,11}).+"
regex = r"https?:\/\/(player.|www.)?(vimeo\.com|youtu(be\.com|\.be))\/(video\/|embed\/|watch\?v=|v\/)?([A-Za-z0-9]{1,11}).+" # noqa

54
apps/map/views.py
View File

@ -1,10 +1,12 @@
import logging
import json
from django.shortcuts import get_object_or_404
from django.conf import settings
from django.contrib.auth.mixins import LoginRequiredMixin, UserPassesTestMixin
from django.core.mail import send_mail
from django.db.models import Q
from django.http import Http404, HttpResponse
from django.http import HttpResponse
from django.urls import reverse
from django.urls import reverse_lazy
from django.utils.translation import get_language
@ -17,9 +19,12 @@ from dal import autocomplete
from apps.files.models import File
from .models import CaseStudy, CaseStudyDraft, SpatialRefSys, PointOfInterest
from .forms import ShortCaseStudyForm, LongCaseStudyForm, PointOfInterest
from . import models
from . import forms
from .models import CaseStudy, CaseStudyDraft, SpatialRefSys
from .forms import ShortCaseStudyForm, LongCaseStudyForm
logger = logging.getLogger(__name__)
NOTIFY_MESSAGE = """
Hello,
@ -47,8 +52,8 @@ class CreatePointOfInterest(LoginRequiredMixin, CreateView):
template_name = "map/form-poi.html"
success_url = "/case-study/create/success/"
model = PointOfInterest
form_class = PointOfInterest
model = models.PointOfInterest
form_class = forms.PointOfInterest
def send_email(study_id):
@ -67,10 +72,10 @@ def send_email(study_id):
fail_silently=False,
)
except:
except Exception:
logging.exception("Sending mail failed")
# XXX This is bad. We should do something more useful with the error
# than this.
pass
def delete_user_draft(user_id):
@ -200,38 +205,26 @@ class DraftsAPI(LoginRequiredMixin, View):
XXX This should be refactored to use csrf protection.
"""
def get_object(self, request):
try:
return CaseStudyDraft.objects.get(author=request.user)
except:
return None
def get(self, request):
draft = self.get_object(request)
draft = get_object_or_404(models.CaseStudyDraft, author=request.user)
if draft == None:
return HttpResponse(status=404) # Not Found
else:
return HttpResponse(draft.data, content_type="application/json")
def put(self, request):
# Find an existing object is there is one
draft = self.get_object(request)
if draft == None:
# If there isn't, create a new draft...
draft = CaseStudyDraft(author=request.user, data=request.body.decode())
draft.save()
return HttpResponse(status=201) # Created
else:
try:
draft = CaseStudyDraft.objects.get(author=request.user)
draft.data = request.body.decode()
draft.save()
return HttpResponse(status=200) # OK
def delete(self, request):
draft = self.get_object(request)
except models.CaseStudyDraft.DoesNotExist:
# If it doesn't exist, create it
CaseStudyDraft.objects.create(author=request.user, data=request.body.decode())
return HttpResponse(status=201) # Created
def delete(self, request):
draft = get_object_or_404(models.CaseStudyDraft, author=request.user)
if draft != None:
data = json.loads(draft.data)
for k in [
@ -240,7 +233,6 @@ class DraftsAPI(LoginRequiredMixin, View):
"shapefiles",
"images",
]:
try:
keyname = k + "_files"
field = data["data"]["form"][keyname]
@ -261,7 +253,7 @@ class DraftsAPI(LoginRequiredMixin, View):
except File.DoesNotExist:
continue
except:
except Exception: # XXX What are we guarding against here?
continue
draft.delete()

2
apps/map/widgets.py
View File

@ -50,5 +50,5 @@ class JSONFileListWidget(widgets.HiddenInput):
try:
filelist = json.loads(value)
return [file["id"] for file in filelist]
except JSONDecodeError:
except json.JSONDecodeError:
return None

2
apps/profiles/admin.py
View File

@ -1,3 +1,3 @@
from django.contrib import admin
# from django.contrib import admin
# Register your models here.

2
apps/profiles/models.py
View File

@ -1,3 +1,3 @@
from django.db import models
# from django.db import models
# Create your models here.

2
apps/profiles/tests.py
View File

@ -1,3 +1,3 @@
from django.test import TestCase
# from django.test import TestCase
# Create your tests here.

2
manage.py
View File

@ -11,7 +11,7 @@ if __name__ == "__main__":
# issue is really that Django is missing to avoid masking other
# exceptions on Python 2.
try:
import django
import django # noqa
except ImportError:
raise ImportError(
"Couldn't import Django. Are you sure it's installed and "

15
ojusomap/settings.py
View File

@ -13,6 +13,7 @@ https://docs.djangoproject.com/en/1.11/ref/settings/
import os
import raven
from django.utils.translation import ugettext_lazy as _
from django.contrib.messages import constants as messages
# Build paths inside the project like this: os.path.join(BASE_DIR, ...)
BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
@ -257,14 +258,22 @@ LEAFLET_CONFIG = {
"https://{s}.tile.opentopomap.org/{z}/{x}/{y}.png",
{
"maxZoom": 17,
"attribution": 'Map data: &copy; <a href="http://www.openstreetmap.org/copyright">OpenStreetMap</a>, <a href="http://viewfinderpanoramas.org">SRTM</a> | Map style: &copy; <a href="https://opentopomap.org">OpenTopoMap</a> (<a href="https://creativecommons.org/licenses/by-sa/3.0/">CC-BY-SA</a>)',
"attribution": (
'Map data: &copy; <a href="http://www.openstreetmap.org/copyright">OpenStreetMap</a>,'
' <a href="http://viewfinderpanoramas.org">SRTM</a> |'
' Map style: &copy; <a href="https://opentopomap.org">OpenTopoMap</a>'
' (<a href="https://creativecommons.org/licenses/by-sa/3.0/">CC-BY-SA</a>)'
),
},
),
(
"English",
"https://{s}.basemaps.cartocdn.com/light_all/{z}/{x}/{y}{r}.png",
{
"attribution": '&copy; <a href="http://www.openstreetmap.org/copyright">OpenStreetMap</a> &copy; <a href="https://carto.com/attributions">CARTO</a>',
"attribution": (
'&copy; <a href="http://www.openstreetmap.org/copyright">OpenStreetMap</a>'
' &copy; <a href="https://carto.com/attributions">CARTO</a>'
),
"subdomains": "abcd",
"maxZoom": 19,
},
@ -329,8 +338,6 @@ AVATAR_GRAVATAR_DEFAULT = "mm"
AVATAR_CLEANUP_DELETED = True
# Messages
from django.contrib.messages import constants as messages
MESSAGE_TAGS = {messages.ERROR: "danger"}
# Feature flags

8
ojusomap/tests.py
View File

@ -5,7 +5,6 @@ from django.contrib.auth.models import User
from django.test import LiveServerTestCase
from selenium import webdriver
from selenium.common import exceptions
from selenium.webdriver.common.by import By
from selenium.webdriver.support.expected_conditions import (
staleness_of,
@ -23,9 +22,10 @@ TIMEOUT = 8
class SeleniumTest(LiveServerTestCase):
@classmethod
def setUpClass(cls):
### To test with firefox, uncomment these lines and comment those pertaining
### to Chrome. However, it will not work with GitLab CI because the docker
### container does not have the geckodriver installed.
# To test with firefox, uncomment these lines and comment those pertaining
# to Chrome. However, it will not work with GitLab CI because the docker
# container does not have the geckodriver installed.
#
# profile = webdriver.FirefoxProfile()
# profile.set_preference("dom.forms.number", False)
# cls.sl = webdriver.Firefox(profile)

6
ojusomap/urls.py
View File

@ -1,13 +1,7 @@
from django.conf.urls import include, url
from django.urls import reverse
from django.conf.urls.i18n import i18n_patterns
from django.contrib import admin
from django.contrib.auth.models import User
from rest_framework import routers, serializers, viewsets
from rest_framework_gis import serializers as gis_serializers
from apps.files.models import File
from apps.map.models import CaseStudy, PointOfInterest
from .views import LanguageDropdownView

8
setup.cfg
View File

@ -1,3 +1,11 @@
[flake8]
max-line-length = 120
exclude = .tox,.git,*/migrations/*,*/static/CACHE/*,docs/*,node_modules
[pycodestyle]
max-line-length = 120
exclude = .tox,.git,*/migrations/*,*/static/CACHE/*,docs,node_modules
[tool:pytest]
DJANGO_SETTINGS_MODULE = ojusomap.settings
python_files = tests.py test_*.py *_tests.py