Decide if we need an nginx.conf per-project #18

New Issue

3wordchant · 2021-12-10T20:53:49Z

3wordchant commented

2021-12-10 20:53:49 +00:00

The majority of wordpress docker projects I've seen out there assume that every different site will need its own special unique nginx.conf, so template repositories and docker stacks / Dockerfiles include one that can be easily customised. I.e. "yes".

Co-op Cloud currently assumes that different instances of "the same app" use the identical, or at most templated, webserver configuration files. Per-app configuration is somewhat-deliberately restricted to environment variables, with editing configuration file seen as a corner case (e.g. for nextcloud single sign-on config).

I'm also not sure I can imagine legitimate difference between the required webserver configuration of different websites, but maybe I'm just not thinking had enough.

So I currently lean towards "no", that we should have one shared file.

If we end up agreeing on "no", a follow-up question is -- how to implement that? One idea could be to build our own image that's basically just upstream nginx with one config file. Alternatively we could include the config file in the PHP container and copy it across in an entrypoint (not amazing security-wise in terms of permissions required).

The majority of wordpress docker projects I've seen out there assume that every different site will need its own special unique nginx.conf, so template repositories and docker stacks / Dockerfiles include one that can be easily customised. I.e. "yes". Co-op Cloud currently assumes that different instances of "the same app" use the identical, or at most templated, webserver configuration files. Per-app configuration is somewhat-deliberately restricted to environment variables, with editing configuration file seen as a corner case (e.g. for nextcloud single sign-on config). I'm also not sure I can imagine legitimate difference between the required webserver configuration of different websites, but maybe I'm just not thinking had enough. So I currently lean towards "no", that we should have one shared file. --- If we end up agreeing on "no", a follow-up question is -- how to implement that? One idea could be to build our own image that's basically just upstream `nginx` with one config file. Alternatively we could include the config file in the PHP container and copy it across in an entrypoint (not amazing security-wise in terms of permissions required).

3wordchant added the

enhancement

label 2021-12-10 20:53:49 +00:00

3wordchant commented

2021-12-16 16:01:40 +00:00

I think we're leaning towards "no". So, time to make a custom nginx image too?

3wordchant referenced this issue from a commit

2021-12-17 10:08:59 +00:00

Switch to our nginx image, drop nginx.conf

3wordchant closed this issue

2021-12-17 10:08:59 +00:00

3wordchant referenced this issue from a commit