Rename STACK_NAME option #63

New Issue

3wordchant · 2020-12-31T09:03:15Z

3wordchant commented

2020-12-31 09:03:15 +00:00

From #47:

STACK_NAME should become APP and APP should be used as the main way to refer to an instance of an app all the way down. So the user types abra deploy to do actions on an app and the internals call the stack with the same value as <app>

STACK_NAME -> APP in the compose.yml and .drone.yml references also (this could be something going forward since it is too much busy work to search/replace all this now)

Currently this would break the somewhat-hidden feature where you can set a STACK_NAME that's completely different to the filename, e.g. our gitea instance lives in a file called git.autonomic.zone.env but the STACK_NAME is "gitea".

We could either decide to drop that feature and require that Docker stack names be the same as .env filenames, or fix the naming collision between the <app> → $APP argument and the new STACK_NAME 🤔 Any thoughts?

From #47: > `STACK_NAME` should become `APP` and `APP` should be used as the main way to refer to an instance of an app all the way down. So the user types abra <app> deploy to do actions on an app and the internals call the stack with the same value as `<app>` > > `STACK_NAME` -> `APP` in the compose.yml and .drone.yml references also (this could be something going forward since it is too much busy work to search/replace all this now) > Currently this would break the somewhat-hidden feature where you can set a `STACK_NAME` that's completely different to the filename, e.g. our gitea instance lives in a file called `git.autonomic.zone.env` but the `STACK_NAME` is "gitea". > > We could either decide to drop that feature and require that Docker stack names be the same as `.env` filenames, or fix the naming collision between the `<app>` → `$APP` argument and the new `STACK_NAME` 🤔 Any thoughts?

3wordchant added the

breaking-change

enhancement

labels 2020-12-31 09:03:31 +00:00

decentral1se referenced this issue from coop-cloud/go-abra

2021-07-22 11:32:06 +00:00

Rename STACK_NAME option #14

decentral1se commented

2021-07-22 11:32:14 +00:00

Will be discussed in coop-cloud/go-abra#14.

Will be discussed in https://git.autonomic.zone/coop-cloud/go-abra/issues/14.

decentral1se closed this issue