coop-cloud/abra
coop-cloud
/
abra
Archived
7
0
Fork 2
Code Issues 21 Pull Requests Releases Activity

app <domain> -> app <app> #47

New Issue
Closed
opened 2020-12-29 12:49:15 +00:00 by decentral1se · 4 comments
decentral1se commented 2020-12-29 12:49:15 +00:00
Owner
Copy Link

https://codimd.autonomic.zone/h1E5ZDaoQ-OeK0M3S4Ap0A

> https://codimd.autonomic.zone/h1E5ZDaoQ-OeK0M3S4Ap0A
decentral1se added the
design
 label 2020-12-29 12:58:26 +00:00
decentral1se added the
breaking-change
 label 2020-12-29 13:05:39 +00:00
decentral1se commented 2020-12-29 15:24:54 +00:00
Author
Owner
Copy Link

Trying to gather the change list...(will edit until we're setteld on them):

  • <domain> -> <app> on the docopt CLI definition
  • Ask for <app> when doing abra app new <type> (like we do for domain) and use this logic to generate <app> defaults if user doesn't specify one
  • .abra/servers/swarm.autonomic.zone/gitea.env -> .abra/servers/swarm.autonomic.zone/git_autonomic_zone.env where the old used the domain name and the new uses the new default for the <app>
  • export APP=gitea in the app env vars should become export TYPE=gitea following #48
  • STACK_NAME should become APP and APP should be used as the main way to refer to an instance of an app all the way down. So the user types abra <app> deploy to do actions on an app and the internals call the stack with the same value as <app>
  • STACK_NAME -> APP in the compose.yml and .drone.yml references also (this could be something going forward since it is too much busy work to search/replace all this now)
Trying to gather the change list...(will edit until we're setteld on them): - `<domain>` -> `<app>` on the docopt CLI definition - Ask for `<app>` when doing `abra app new <type>` (like we do for domain) and use [this logic](https://git.autonomic.zone/coop-cloud/abra/src/branch/main/abra#L405) to generate `<app>` defaults if user doesn't specify one - `.abra/servers/swarm.autonomic.zone/gitea.env` -> `.abra/servers/swarm.autonomic.zone/git_autonomic_zone.env` where the old used the domain name and the new uses the new default for the `<app>` - `export APP=gitea` in the app env vars should become `export TYPE=gitea` following https://git.autonomic.zone/coop-cloud/abra/issues/48 - `STACK_NAME` should become `APP` and `APP` should be used as the main way to refer to an instance of an app all the way down. So the user types `abra <app> deploy` to do actions on an app and the internals call the stack with the same value as `<app>` - `STACK_NAME` -> `APP` in the `compose.yml` and `.drone.yml` references also (this could be something going forward since it is too much busy work to search/replace all this now)
3wordchant commented 2020-12-30 12:08:33 +00:00
Owner
Copy Link
  • <domain> -> <app> on the docopt CLI definition

Done.

  • Ask for <app> when doing abra app new <type> (like we do for domain) and use this logic to generate <app> defaults if user doesn't specify one

Done, although I included TYPE in it, so we get e.g. customhtml_test_swarm_autonomic_zone. Let me know if that seems bad.

  • .abra/servers/swarm.autonomic.zone/gitea.env -> .abra/servers/swarm.autonomic.zone/git_autonomic_zone.env where the old used the domain name and the new uses the new default for the <app>

This is an easy fix with mosh but not technically required, abra doesn't care if the old names have dots or underscores.

  • export APP=gitea in the app env vars should become export TYPE=gitea following #48

Working on it!

  • STACK_NAME should become APP and APP should be used as the main way to refer to an instance of an app all the way down. So the user types abra <app> deploy to do actions on an app and the internals call the stack with the same value as <app>
  • STACK_NAME -> APP in the compose.yml and .drone.yml references also (this could be something going forward since it is too much busy work to search/replace all this now)

Currently this would break the somewhat-hidden feature where you can set a STACK_NAME that's completely different to the filename, e.g. our gitea instance lives in a file called git.autonomic.zone.env but the STACK_NAME is "gitea".

We could either decide to drop that feature and require that Docker stack names be the same as .env filenames, or fix the naming collision between the <app> → $APPargument and the newSTACK_NAME` 🤔 Any thoughts?

> - `<domain>` -> `<app>` on the docopt CLI definition Done. > - Ask for `<app>` when doing `abra app new <type>` (like we do for domain) and use [this logic](https://git.autonomic.zone/coop-cloud/abra/src/branch/main/abra#L405) to generate `<app>` defaults if user doesn't specify one Done, although I included `TYPE` in it, so we get e.g. `customhtml_test_swarm_autonomic_zone`. Let me know if that seems bad. > - `.abra/servers/swarm.autonomic.zone/gitea.env` -> `.abra/servers/swarm.autonomic.zone/git_autonomic_zone.env` where the old used the domain name and the new uses the new default for the `<app>` This is an easy fix with `mosh` but not technically required, `abra` doesn't care if the old names have dots or underscores. > - `export APP=gitea` in the app env vars should become `export TYPE=gitea` following https://git.autonomic.zone/coop-cloud/abra/issues/48 Working on it! > - `STACK_NAME` should become `APP` and `APP` should be used as the main way to refer to an instance of an app all the way down. So the user types `abra <app> deploy` to do actions on an app and the internals call the stack with the same value as `<app>` > - `STACK_NAME` -> `APP` in the `compose.yml` and `.drone.yml` references also (this could be something going forward since it is too much busy work to search/replace all this now) Currently this would break the somewhat-hidden feature where you can set a `STACK_NAME` that's completely different to the filename, e.g. our gitea instance lives in a file called `git.autonomic.zone.env` but the `STACK_NAME` is "gitea". We could either decide to drop that feature and require that Docker stack names be the same as `.env` filenames, or fix the naming collision between the `<app>` → $APP` argument and the new `STACK_NAME` 🤔 Any thoughts?
3wordchant commented 2020-12-30 20:03:49 +00:00
Owner
Copy Link

export APP=gitea in the app env vars should become export TYPE=gitea following #48

Done.

I propose leaving the STACK_NAME → APP rename until later, will open a separate ticket if that's ☮

> export APP=gitea in the app env vars should become export TYPE=gitea following https://git.autonomic.zone/coop-cloud/abra/issues/48 Done. --- I propose leaving the `STACK_NAME` → `APP` rename until later, will open a separate ticket if that's ☮
👍 1
decentral1se commented 2020-12-30 21:24:01 +00:00
Author
Owner
Copy Link

🚆

🚆
3wordchant referenced this issue from a commit 2020-12-31 20:56:20 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:56:38 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:56:42 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:56:46 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:56:50 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:56:57 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:00 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:09 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:13 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:17 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:21 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:24 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:29 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:32 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:36 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:40 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:44 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:47 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:51 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:57:58 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:58:02 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:58:05 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:58:16 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2020-12-31 20:58:20 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2021-01-14 23:02:05 +00:00
APP → TYPE
3wordchant referenced this issue from a commit 2021-03-02 16:43:55 +00:00
APP → TYPE
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
main
requirements-install-script
prefer-fast-option
add-bump-logic
prompt-cleanup
fix-pwgen
fix-subcommand-select
digest-version
backup_restore
command_help_2
merge-logging
monorepo
10.0.0
9.0.0
8.0.1
8.0.0
0.7.4
0.7.3
0.7.2
0.7.1
0.7.0
checkout
0.6.0
0.5.0
0.4.1
0.4.0
0.3.1
0.3.0
0.2.0
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
breaking-change

Anything that breaks the existing API

  
bug

Something is not working

  
CI/CD

Anything to do with testing and infra

  
design

Anything to with UX of this tool

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
plugin

Related to the plugin architecture

  
question

More information is needed

  
secrets

Everything to do with docker secrets

  
shell-completion

To do with shell completion

  
versioning

All the things to do with versioning apps

  
wontfix

This won't be fixed

No Label
breaking-change
bug
CI/CD
design
documentation
duplicate
enhancement
help wanted
invalid
plugin
question
secrets
shell-completion
versioning
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#47
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?