Show git digest in abra version if we're running a development version #103

3wordchant · 2021-03-16T11:05:19Z

3wordchant commented

2021-03-16 11:05:19 +00:00

Closes #100

This isn't perfect, because it'll blow up if:

~/.local/bin/abra is a symlink to the downloaded abra script, but not a git checkout
Or if we run abra from the checkout, not using a symlink

But neither of these situations is likely gonna be that common.

In the simple case:

$ abra version
0.5.0-23c8521

Whaddya reck?

Closes #100 This isn't perfect, because it'll blow up if: 1. `~/.local/bin/abra` is a symlink to the downloaded `abra` script, but not a git checkout 2. Or if we run abra from the checkout, not using a symlink But neither of these situations is likely gonna be that common. In the simple case: ``` $ abra version 0.5.0-23c8521 ``` Whaddya reck?

3wordchant added 2 commits 2021-03-16 11:05:20 +00:00

8b4141670c Include git digest in dev `version` output

Re: #100

continuous-integration/drone/pr Build is passing Details

c00319ab01 Update CHANGELOG

decentral1se approved these changes 2021-03-16 11:26:07 +00:00

decentral1se left a comment

Nice! LGTM!

Or if we run abra from the checkout, not using a symlink

Wanna update the README to remove the hacking tip that says just run ./abra? I think this is fine since we give clear guidelines how to get hacking on it (just use --dev)

Nice! LGTM! > Or if we run abra from the checkout, not using a symlink Wanna update the README to remove the hacking tip that says just run `./abra`? I think this is fine since we give clear guidelines how to get hacking on it (just use `--dev`)

decentral1se merged commit 293d3ff558 into main

2021-03-17 11:48:46 +00:00

decentral1se referenced this issue from a commit

2021-03-17 11:48:46 +00:00

Merge pull request 'Show git digest in `abra version` if we're running a development version' (#103) from digest-version into main

This repo is archived. You cannot comment on pull requests.

No reviewers