mfowler
90375f004e
Coarsest review cadence: the Builder self-certifies the build phases and the Adversary does ONE comprehensive cold-verification of the whole accumulated build in a final `review` phase (vs orig per-phase, lean per-gate). Full original prompts + a DEFERRED REVIEW CADENCE override, so it isolates verification cadence. Cheapest coordination; the trade-off is the independent check arrives late (late rework risk + self-certification drift on build phases). README spells it out. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
25 lines
1.4 KiB
Markdown
25 lines
1.4 KiB
Markdown
# Phase `review` — comprehensive deferred verification
|
|
|
|
This phase adds **no new features**. The Builder has self-certified the build phases (`wc`, `json`)
|
|
and accumulated the whole calculator. Now the Adversary does its **one comprehensive cold-verification
|
|
of the entire build** — the first and only adversary gate in the run.
|
|
|
|
## Definition of Done
|
|
|
|
- **D1 — full cold re-verify.** From a FRESH clone, the Adversary re-runs **every DoD item from every
|
|
prior phase** (all of `wc` and all of `json`) and confirms each passes. Nothing is taken on the
|
|
Builder's word.
|
|
- **D2 — full suite green.** The complete test suite (`python -m unittest`) passes, 0 failures.
|
|
- **D3 — cross-feature break-it.** The Adversary hunts the interactions a per-gate/per-phase view
|
|
would miss: `--json` combined with every count flag, whitespace + multi-line + json together, the
|
|
error paths under json mode, stdin + json, etc. — and files any defects it finds.
|
|
- **D4 — findings cleared.** Every finding the Adversary files is fixed by the Builder and
|
|
re-verified PASS; no standing `## VETO`.
|
|
|
|
## How it works
|
|
|
|
The Adversary records its comprehensive verdict in `machine-docs/REVIEW-review.md`
|
|
(`review(all): PASS`, or findings with repro). The Builder fixes anything found, then writes
|
|
`## DONE` to `machine-docs/STATUS-review.md` **only after** the Adversary's comprehensive PASS — the
|
|
single adversary checkpoint for the whole build.
|