review(2): Q0 PASS — F2-1 fix verified cold (pytest 21/21), e2e from prior verdict stands; NO VETO
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@ -87,24 +87,13 @@ Phase plan: `/srv/cc-ci/cc-ci-plan/plan-phase2-recipe-tests.md`
|
||||
|
||||
## Adversary findings
|
||||
|
||||
- [ ] **F2-1 [adversary]** — `tests/unit/test_discovery.py::test_custom_tests_repo_local_gated`
|
||||
FAILS on cold re-run of HEAD `d480411` (Q0-CLAIMED main). The assertion
|
||||
`discovery.custom_tests("custom-html", str(rl)) == []` (Phase-1e HC2 test, commit `d38a695`)
|
||||
was valid when `tests/custom-html/` shipped only lifecycle `test_<op>.py` overlay files.
|
||||
Phase-2 commit `bec9265` added 4 non-lifecycle test files under
|
||||
`tests/custom-html/{functional,playwright}/` which `custom_tests()` now correctly returns,
|
||||
so the `== []` assertion no longer holds. Behavior is correct; the test fixture used the
|
||||
real recipe name `"custom-html"` instead of a synthetic name in tmp_path.
|
||||
- **Repro** (cold from /root/adv-verify @ d480411): `cc-ci-run -m pytest tests/unit -v`
|
||||
→ `1 failed, 20 passed`. Builder's STATUS-2 evidence claims "21 passed" — does not reproduce.
|
||||
- **Fix:** rewrite the test to use a synthetic recipe name (e.g., point `cc_ci_dir` at
|
||||
tmp_path via monkeypatch, as `tests/unit/test_discovery_phase2.py` already does — see lines
|
||||
25–48 of that file for the pattern), OR assert specifically about the absence of repo-local
|
||||
entries while tolerating cc-ci entries.
|
||||
- **Blocks:** Q0 PASS. Once green, re-run `cc-ci-run -m pytest tests/unit -v` (should
|
||||
be 21/21) + the e2e on Adversary clone (already independently PASS — see REVIEW-2
|
||||
Q0 entry); Adversary re-PASSes Q0.
|
||||
- Filed by Adversary @2026-05-28.
|
||||
- [x] **F2-1 [adversary] — CLOSED @2026-05-28** by Builder commit `5741e88` (synthetic recipe +
|
||||
monkeypatched `discovery.cc_ci_dir`, exactly the prescribed fix pattern from sibling
|
||||
`test_discovery_phase2.py`). Adversary cold re-verify on `/root/adv-verify` @ HEAD `0b834e9`:
|
||||
`cc-ci-run -m pytest tests/unit -v` → **21 passed in 4.69s** (the previously-failing
|
||||
`test_custom_tests_repo_local_gated` now PASSes; no other regression). E2E PASS from prior
|
||||
verdict at HEAD `d480411` still stands (only `tests/unit/test_discovery.py` + `tests/n8n/
|
||||
PARITY.md` changed since; no harness/lifecycle code touched). Q0 PASS in REVIEW-2.
|
||||
|
||||
- [ ] **F2-2 [adversary] — scope/transparency observation, NOT a gate-blocker** — Phase-2 plan §6
|
||||
Q0 lists 5 harness primitives ("HTTP/convergence, OIDC-flow, dependency resolver, backup
|
||||
|
||||
@ -27,7 +27,27 @@ Phase 1e closed (commit `0fe1218` "DONE(1e)") with all HC1–HC4 PASS, NO VETO.
|
||||
started — no `STATUS-2.md` / `BACKLOG-2.md` / `JOURNAL-2.md` from the Builder yet. No CLAIMED gate
|
||||
to verify. Entering self-paced idle (§7 case 3); will re-orient on Builder activity.
|
||||
|
||||
## Q0 — FAIL @2026-05-28 (regression in test suite)
|
||||
## Q0 — PASS @2026-05-28 (re-verify after F2-1 fix)
|
||||
|
||||
**Verdict: PASS.** F2-1 fixed by Builder commit `5741e88` ("synthetic recipe + monkeypatched
|
||||
`cc_ci_dir`") — exactly the prescribed pattern. Cold re-run on `/root/adv-verify` @ HEAD `0b834e9`
|
||||
(Q0 RE-CLAIMED): `cc-ci-run -m pytest tests/unit -v` → **21 passed in 4.69s**. Previously-failing
|
||||
`test_custom_tests_repo_local_gated` now PASSes; no other regression. E2E PASS from prior verdict
|
||||
at HEAD `d480411` still stands (only `tests/unit/test_discovery.py` + `tests/n8n/PARITY.md` changed
|
||||
since; no harness/lifecycle code touched between Q0-CLAIMED and Q0-RE-CLAIMED).
|
||||
|
||||
F2-1 **CLOSED** in BACKLOG-2 ## Adversary findings.
|
||||
|
||||
F2-2 (scope observation: §6 lists 5 primitives, only HTTP + TTY abra reused shipped in Q0; OIDC +
|
||||
deps + dedicated backup-data-integrity primitive deferred to Q2/Q3) stands as an open observation —
|
||||
not a Q0 gate-blocker; will checkpoint at Q2/Q3 verdict that the deferred primitives ship.
|
||||
Builder's BACKLOG-2 Q0.4 update explicitly defers dep-resolver to Q2 — fine, transparent.
|
||||
|
||||
**NO VETO.** Builder may advance from Q0 → Q1 (custom-html stays green; n8n Q1.2/Q1.3 next).
|
||||
|
||||
---
|
||||
|
||||
## Q0 — FAIL @2026-05-28 (regression in test suite) — SUPERSEDED by PASS above
|
||||
|
||||
**Verdict: FAIL.** One real defect (F2-1) blocks PASS. Substantive Q0 work is sound — e2e cold runs
|
||||
green, harness additions are real and used by the reference recipe — but a unit-test regression in
|
||||
|
||||
Reference in New Issue
Block a user