review(5): A5-5 CLOSED — accurate comment #13900 + RESULT log verified cold
Some checks failed
continuous-integration/drone/push Build is failing

This commit is contained in:
autonomic-bot
2026-06-01 21:49:44 +00:00
parent ffb62f1006
commit 6939cedd16
2 changed files with 30 additions and 1 deletions

View File

@ -26,7 +26,8 @@ Single-writer: `## Build backlog` = Builder-only; `## Adversary findings` = Adve
## Adversary findings
### [adversary] A5-5 — V5: explanatory comment references wrong build/failures; no RESULT: SUCCESS-PENDING-TESTS
**Status:** OPEN — found 2026-06-01T21:38Z
**Status:** CLOSED — re-tested 2026-06-01T21:49Z; see `REVIEW-5.md` follow-up entry.
ORIGINALLY OPEN — found 2026-06-01T21:38Z
V5 requires the `recipe-upgrade` skill in DEFAULT mode (no `--with-tests`) to: post an explanatory
comment that accurately identifies which test is stale + why; and report `RESULT: SUCCESS-PENDING-TESTS`.

View File

@ -449,3 +449,31 @@ should run the skill end-to-end and produce the RESULT line to fully satisfy V6.
cross-links, nothing merged) is present and independently verified. The missing RESULT line is noted
but does not change the verdict given that all observable outputs are correct. If Builder runs the
skill end-to-end, the RESULT line will confirm it.
---
## A5-5 cold-verify: CLOSED — 2026-06-01T21:49Z
Builder's STATUS-5.md claims A5-5 is fixed: re-ran full `/recipe-upgrade custom-html` DEFAULT skill
against seeded PR#3 (head `71e7326a`); build #81; accurate comment #13900; RESULT log written.
I did **not** read `JOURNAL-5.md` before this verdict.
**Cold repro ran:**
1. Comment #13900 on `recipe-maintainers/custom-html` PR#3 (fetched via Gitea API):
- Created: `2026-06-01T21:43:01Z`
- References: `build #81` (correct — not #40)
- Root cause: `application/octet-stream` vs `text/plain` for `.txt` MIME type (correct — no docroot-path confusion)
- Structure: accurate table (install✅ upgrade✅ backup✅ restore✅ custom❌)
- Stale test identified: `tests/custom-html/functional/test_content_type_header.py::test_content_type_html_and_txt` ✓
- No test modifications noted ✓
- Instructions to re-run `--with-tests` ✓
- Finding 1 RESOLVED ✓
2. RESULT log `/srv/cc-ci/.cc-ci-logs/upgrades/custom-html-upgrade-2026-06-01.md`:
- EXISTS (size 1622 bytes) ✓
- Final line: `RESULT: SUCCESS-PENDING-TESTS — custom-html 1.10.0+1.28.0 → 1.11.2+1.29.0, recipe PR: .../custom-html/pulls/3; !testme RED on a stale test (commented; re-run --with-tests to update tests)` ✓
- Finding 2 RESOLVED ✓
**Verdict: A5-5 CLOSED.** Both requirements (accurate comment referencing build #81 with correct MIME-type
root cause, and RESULT: SUCCESS-PENDING-TESTS log) are now satisfied by cold verification.