review(5): correct A5-6 — finding 2 retracted, bridge fix confirmed, awaiting V8 run
Some checks failed
continuous-integration/drone/push Build is failing
Some checks failed
continuous-integration/drone/push Build is failing
This commit is contained in:
@ -81,16 +81,10 @@ cold verification:
|
||||
`2026-06-01T21:48:39Z`), the bridge will NEVER pick it up.
|
||||
- `POST=1 testme-on-pr.sh uptime-kuma 1` will eventually time out and return `VERDICT=PENDING BUILD=?`.
|
||||
|
||||
**Blocker 2 — uptime-kuma has no tests/ directory in cc-ci:**
|
||||
- `ls /root/builder-clone/tests/` on cc-ci shows: `bluesky-pds cryptpad custom-html custom-html-tiny
|
||||
discourse _generic ghost immich keycloak lasuite-docs lasuite-drive lasuite-meet mailu
|
||||
matrix-synapse mattermost-lts mumble n8n plausible`
|
||||
- `uptime-kuma` is absent. Even if the bridge were to trigger a CI run, it would fail with no
|
||||
recipe-specific tests to run (only generic harness stages).
|
||||
~~**Blocker 2 — uptime-kuma has no tests/ directory in cc-ci (RETRACTED)**~~
|
||||
Builder's correction verified: `ls /root/builder-clone/tests/uptime-kuma/` → EXISTS (functional/ PARITY.md recipe_meta.py). Phase 2 commit `1aaf3bd`. This finding was incorrect.
|
||||
|
||||
**Impact:** The V8 live run evidence is invalid — `uptime-kuma` is not a properly enrolled recipe.
|
||||
The `/upgrade-all` dry-run survey listed it as a candidate because `abra recipe upgrade` found
|
||||
available upgrades, but that check is independent of bridge enrollment or test coverage.
|
||||
**Impact:** The V8 live run evidence was invalid at time of filing — `uptime-kuma` was not in bridge POLL_REPOS. The tests/ directory DOES exist (finding 2 was incorrect). The `/upgrade-all` dry-run survey listed it as a candidate because `abra recipe upgrade` found available upgrades, which is independent of bridge enrollment.
|
||||
|
||||
**Cold repro:**
|
||||
1. `ssh cc-ci '/run/current-system/sw/bin/docker service logs ccci-bridge_app 2>&1 | grep "watching\|uptime"'`
|
||||
@ -100,16 +94,14 @@ available upgrades, but that check is independent of bridge enrollment or test c
|
||||
4. Check commit status: `GET /repos/recipe-maintainers/uptime-kuma/commits/728618890a2b/status`
|
||||
→ `state:'', total_count:0` after the `!testme` comment was already posted
|
||||
|
||||
**Required fix:**
|
||||
Either (a) for V8 re-run: use already-enrolled recipes (n8n, cryptpad, or lasuite-meet have live
|
||||
upgrade candidates) and add them both to POLL_REPOS and have tests/ directories, OR
|
||||
(b) first enroll `uptime-kuma` properly: add `tests/uptime-kuma/` to cc-ci and add
|
||||
`recipe-maintainers/uptime-kuma` to bridge POLL_REPOS, redeploy bridge, THEN run V8.
|
||||
**Fix applied (commit `51ba205`):** Added `recipe-maintainers/uptime-kuma` to POLL_REPOS in bridge.nix. Bridge redeployed (container `9mtdhzx7eylf`). Upgrader restarted at 21:54:25Z.
|
||||
|
||||
Also: the `/upgrade-all` skill should validate that a recipe is enrolled (bridge + tests) before
|
||||
adding it to the candidate list, or at minimum warn when a candidate lacks tests/.
|
||||
**Cold-verify of fix:**
|
||||
- New bridge container `9mtdhzx7eylf` confirms `uptime-kuma` in poll list ✓
|
||||
- `tests/uptime-kuma/` verified present ✓ (finding 2 was incorrect)
|
||||
- Awaiting first `!testme` trigger to confirm bridge picks up the run
|
||||
|
||||
(Only Adversary closes this after cold-verify of a successful live V8 run with an enrolled recipe.)
|
||||
(Only Adversary closes this after cold-verify of a successful live V8 run with uptime-kuma.)
|
||||
|
||||
---
|
||||
|
||||
|
||||
Reference in New Issue
Block a user