review(5 V2): close A5-3 after cold rerun PASS
This commit is contained in:
@ -26,7 +26,7 @@ Single-writer: `## Build backlog` = Builder-only; `## Adversary findings` = Adve
|
||||
## Adversary findings
|
||||
|
||||
### [adversary] A5-3 — `POST=1 testme-on-pr.sh` can return a stale prior GREEN on re-runs
|
||||
**Status:** OPEN — found 2026-06-01T03:22:00Z.
|
||||
**Status:** CLOSED — re-tested 2026-06-01T03:31:30Z; see `REVIEW-5.md` follow-up entry.
|
||||
|
||||
The helper currently posts a fresh `!testme`, then polls the recipe PR head's combined commit status.
|
||||
If that PR head SHA already has a previous successful `cc-ci/testme` status and the bridge has not yet
|
||||
|
||||
@ -180,3 +180,26 @@ probe. I did **not** read `JOURNAL-5.md` before forming this verdict.
|
||||
**Verdict:** FAIL for this V2 edge. Re-triggering `!testme` on an unchanged PR head can race against an
|
||||
older terminal commit status, causing `POST=1` to report the wrong run/result. Filed as
|
||||
`BACKLOG-5.md` item **A5-3**.
|
||||
|
||||
---
|
||||
|
||||
## Cold-verify follow-up — 2026-06-01T03:31:30Z
|
||||
|
||||
No `Gate: <Mn> CLAIMED` was pending in `STATUS-5.md`, so I used the idle slot for a fresh re-test of
|
||||
the open A5-3 rerun bug. I did **not** read `JOURNAL-5.md` before this verdict update.
|
||||
|
||||
### A5-3 re-test: CLOSED
|
||||
- Cold-shell invocation:
|
||||
`POST=1 MAX_WAIT=80 INTERVAL=5 /srv/cc-ci/.claude/skills/recipe-upgrade/testme-on-pr.sh custom-html-tiny 5`
|
||||
- The helper posted a fresh `!testme` and returned:
|
||||
`VERDICT=GREEN`
|
||||
`BUILD=https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/45`
|
||||
- This time the build URL was **fresh**, not the stale prior run URL (`#37`) that previously caused the
|
||||
failure.
|
||||
- Live recipe PR state immediately after the call confirms the head SHA now carries the new
|
||||
`cc-ci/testme` target URL `/45`, with `updated_at=2026-06-01T03:31:18Z`.
|
||||
- Latest PR comments show exactly one new `!testme` trigger comment for this re-test (`#13828` at
|
||||
`2026-06-01T03:30:33Z`).
|
||||
|
||||
**Verdict:** the stale-status rerun bug from A5-3 is no longer reproducible. The fix described in
|
||||
`STATUS-5.md` holds under a cold re-run of the same PR head.
|
||||
|
||||
Reference in New Issue
Block a user