runner: never embed a fossil screenshot from a collided run dir

Conversation 0 Commits 2 Files Changed 5

+169 -5

2 Commits

Author	SHA1	Message	Date
autonomic-bot	8e7008e422	tests: unit coverage for the fossil-screenshot fix continuous-integration/drone/push Build is passing Details (follow-up to previous commit — test appends initially landed in the wrong clone; content identical)	2026-10-05 17:38:21 +00:00
autonomic-bot	934ec8b8f0	runner: never embed a fossil screenshot from a collided run dir continuous-integration/drone/push Build is passing Details !testme gitea PR #10 (drone build 35, 2026-10-05) rendered a summary card whose app screenshot was custom-html-tiny's — a fossil from a May-31 run dir with the same number. Root cause chain: - /var/lib/cc-ci-runs/ keeps old-era run dirs numbered up to 1377; drone's build counter restarted when its DB was re-created (2026-09-27), so new builds collide with old dirs (35 was one). - the run reused the collided dir without cleaning it: fresh results.json/ summary.* landed NEXT TO the old screenshot.png. - screenshot.capture()'s SCREENSHOT-hook branch skipped the actual snap when out_path already existed ('the hook may have saved it' — no hook does), so capture() 'succeeded' without writing and the card embedded the fossil. Fix, cosmetics-only (R7 — verdict logic untouched): - results.fresh_artifact_dir(): at run start, remove ONLY the files/dirs this run owns (results.json, summary.*, badge.svg, lint.txt, screenshot.png, junit/) from its artifact dir; anything else is left alone; never raises. - run_recipe_ci calls it right after computing run_artifact_dir. - screenshot.capture(): the hook branch ALWAYS snaps (same settle/blank-retry path as the default branch) — a pre-existing file is never trusted. Unit tests: fresh_artifact_dir (owned-only removal, dir creation, odd entries) + capture() fake-playwright regression proving a fossil out_path is overwritten.	2026-10-05 17:37:43 +00:00

Author

SHA1

Message

Date

autonomic-bot

8e7008e422

tests: unit coverage for the fossil-screenshot fix

continuous-integration/drone/push Build is passing

Details

(follow-up to previous commit — test appends initially landed in the wrong
clone; content identical)

2026-10-05 17:38:21 +00:00

autonomic-bot

934ec8b8f0

runner: never embed a fossil screenshot from a collided run dir

continuous-integration/drone/push Build is passing

Details

!testme gitea PR #10 (drone build 35, 2026-10-05) rendered a summary card whose
app screenshot was custom-html-tiny's — a fossil from a May-31 run dir with the
same number. Root cause chain:
- /var/lib/cc-ci-runs/ keeps old-era run dirs numbered up to 1377; drone's
  build counter restarted when its DB was re-created (2026-09-27), so new
  builds collide with old dirs (35 was one).
- the run reused the collided dir without cleaning it: fresh results.json/
  summary.* landed NEXT TO the old screenshot.png.
- screenshot.capture()'s SCREENSHOT-hook branch skipped the actual snap when
  out_path already existed ('the hook may have saved it' — no hook does), so
  capture() 'succeeded' without writing and the card embedded the fossil.

Fix, cosmetics-only (R7 — verdict logic untouched):
- results.fresh_artifact_dir(): at run start, remove ONLY the files/dirs this
  run owns (results.json, summary.*, badge.svg, lint.txt, screenshot.png,
  junit/) from its artifact dir; anything else is left alone; never raises.
- run_recipe_ci calls it right after computing run_artifact_dir.
- screenshot.capture(): the hook branch ALWAYS snaps (same settle/blank-retry
  path as the default branch) — a pre-existing file is never trusted.

Unit tests: fresh_artifact_dir (owned-only removal, dir creation, odd entries)
+ capture() fake-playwright regression proving a fossil out_path is overwritten.

2026-10-05 17:37:43 +00:00

runner: never embed a fossil screenshot from a collided run dir #45