40 lines
2.1 KiB
Markdown
40 lines
2.1 KiB
Markdown
# REVIEW — phase aoeng (Adversary log)
|
|
|
|
Phase plan: `/srv/cc-ci/cc-ci-plan/plan-phase-aoeng-engine.md`
|
|
Deliverable repo: `recipe-maintainers/agent-orchestrator` on git.autonomic.zone
|
|
|
|
---
|
|
|
|
## Adversary orientation @2026-06-13T18:23Z
|
|
|
|
Pre-build orientation complete. Key facts noted for cold verification:
|
|
|
|
**DoD items to verify (from phase plan):**
|
|
1. `recipe-maintainers/agent-orchestrator` exists; `main` pushed; `v0.1.0` annotated tag present.
|
|
2. **No cc-ci hardcoding:** `grep -rIE 'cc-ci|/srv/cc-ci|recipe|upgrad' <repo> --include='*.py'` on a clean /tmp checkout returns only generic/example/comment hits.
|
|
3. `python3 agents.py selftest` passes; `python3 agents.py status --config agents.example.toml` prints sane table; `agents.py --help` documents verbs.
|
|
4. Example project smoke run: bring up + tear down in isolated sandbox (own `session_prefix`, throwaway sessions), using ONLY files in repo.
|
|
5. Nix: `flake.nix`+`flake.lock` committed; `nix develop -c python3 -c 'import tomllib'` succeeds; `tmux`/`git` on PATH in devShell.
|
|
6. README documents: schema + verbs + AI-PO usage + `nix develop`.
|
|
|
|
**Specific hardcoding to watch for in the ported agents.py (from source analysis):**
|
|
- `log_dir` default `/srv/cc-ci/.cc-ci-logs` → must be project-rooted / config-driven
|
|
- `session_prefix` default `cc-ci-` → must require from config (no implicit default)
|
|
- `build_loop_kickoff()` hardcoded `*** cc-ci SUB-PHASE ***` preamble → must be template file from config
|
|
- `handoff.repo` default `/srv/cc-ci/cc-ci` → must be config-driven
|
|
- `cwd` fallback `/srv/cc-ci-orch` and `/srv/cc-ci-orch/cc-ci` → must be config-driven
|
|
- `on_complete.run = "upgrader"` → must be generic task name from config
|
|
- `opencode.preamble` has `/srv/cc-ci/.testenv` → must be config-driven
|
|
|
|
**Guardrails to enforce:**
|
|
- Do NOT modify live launch system at `/srv/cc-ci/cc-ci-plan/agents.py`, `agents.toml`, `cc-ci-plan/state/`, or running tmux sessions
|
|
- New repo must be separate from cc-ci tree
|
|
|
|
**Repo state at orientation:** `recipe-maintainers/agent-orchestrator` EXISTS on Gitea but is EMPTY (Builder created shell; no content yet)
|
|
|
|
---
|
|
|
|
## Verdicts
|
|
|
|
*(none yet — waiting for Builder to make claims)*
|