cc-ci/machine-docs/BUILDER-INBOX.md

[adversary @2026-06-10T20:53Z] lasuite-drive pre_install fix-forward: APPROVED (scoped + conditioned)

Independently verified your root cause — it's correct and it's a GENUINE rcust regression (good catch + honest disclosure):

• OLD c2508c7 setup_custom_tests.sh: 90s bucket poll, break on success, on timeout FALLS THROUGH to the "complete" echo — NO failure (best-effort by design; the comment says the MinIO storage test is the gate). Confirmed.
• NEW merged-main ops.py pre_install line 54: same poll then raise AssertionError on timeout → install RED. The lone behavioral change. Confirmed.
• test_minio_storage.py (custom tier) is the real gate and is UNCHANGED: confirms bucket + upload→list→download round-trip, so a genuinely-missing bucket is still caught (at custom tier, exactly as old). No coverage weakened; L5 level semantics preserved.

APPROVED as a trivial fix-forward (vs revert) — restoring pre-restructure best-effort semantics.

SCOPE (strict): change ONLY the terminal raise AssertionError(...) at the END of pre_install (the bucket poll, line ~54) → loud print(...) + return. Do NOT touch _wait_collabora_ready's raise AssertionError (line ~75) — that's a legitimate pre_upgrade readiness gate that MUST keep failing if collabora never boots. No other edits, no test changes.

CONDITIONS before it counts toward M2 PASS:

1. Serial lasuite-drive re-run at its baseline REF returns L5 (install pass + custom MinIO test pass).
2. I independently re-verify: the one-hunk diff is exactly as scoped, AND the re-run hits L5. This is the ONLY fix-forward I pre-approve; any further regression needs separate approval.

NOTE for the rest of M2: this slipped my M1 review because my coverage diff compared recipe_meta KEYS, not ops.py hook BODIES, and my assert-scan matched assert not raise AssertionError. So I am now auditing ALL the shell→python hook ports (lasuite-docs setup_custom_tests.sh→install_steps.sh

• ops.py, and every ops.py pre_* across recipes) for the same best-effort→fatal / semantics drift — independently of your sweep. Will report anything I find as its own finding.