Mechanical port to the assertion-only contract (no softened/skipped assertions): install uses live_app + generic.assert_serving (extend) + the recipe's http/playwright/api checks; upgrade seeds its data marker then generic.do_upgrade + asserts survival; backup/restore split into test_backup.py (seed->do_backup->mutate) + new test_restore.py (do_restore->assert original). Recipe-specifics preserved verbatim (keycloak realm+admin-console+kc_admin, matrix/lasuite db-service psql markers, cryptpad/n8n volume markers). No recipe now double-deploys under the deploy-once orchestrator. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4.7 KiB
STATUS — Phase 1d (generic test suite + layered recipe overlays)
Phase plan (SSOT): /srv/cc-ci/cc-ci-plan/plan-phase1d-generic-test-suite.md
Loop state for THIS phase: STATUS-1d / BACKLOG-1d / REVIEW-1d / JOURNAL-1d (DECISIONS.md shared).
The repo's STATUS.md/BACKLOG.md/REVIEW.md (Phase 1) and STATUS-1b/1c (DONE) are HISTORY, not this
phase's state.
Phase
Phase 1d runs after Phase 1b (DONE) and before Phase 2. It is the test-architecture foundation: every recipe gets a generic lifecycle suite for free; recipe-specific tests layer on top (override-or-extend). Bounded — build the architecture + prove it on a couple of recipes; full per-recipe overlay authoring is Phase 2.
Definition of Done (Phase 1d) — DG1–DG8, each Adversary cold-verified in REVIEW-1d
- DG1 — Generic INSTALL test (recipe-agnostic): app new→deploy→converged→really serving (real HTTP(S), not Traefik fallback). Green on a simple recipe with no cc-ci/repo-local tests. Adversary PASS @2026-05-27 (cold, hedgedoc, deploy-count=1, clean teardown).
- DG2 — Generic UPGRADE: previous/pinned → upgrade to target; reconverge + still serving. Adversary PASS @2026-05-28 (genuine 1.10.7→1.10.8 move + no-op guard raises; F1d-2 closed).
- DG3 — Generic BACKUP+RESTORE for backup-capable recipes; clean N/A (skip) otherwise. Adversary PASS @2026-05-28 (backup snapshot_id artifact + healthy restore on hedgedoc). N/A-skip run-demo green: custom-html-tiny (non-backup-capable) → backup/restore = skip (G3 Run B).
- DG4 — Layering (override-or-extend; generic is the default); discovery + cc-ci/repo-local precedence settled in DECISIONS. Invariant: no overlay for an op ⇒ generic runs. Adversary PASS @2026-05-28 (override LIVE on custom-html's 4 ops + extend + precedence 5/5).
- DG4.1 — Overlays reuse the deployment: ONE deploy + ONE teardown per run; no extra new/deploy/undeploy (assert via deploy-count). Adversary PASS @2026-05-28 (deploy-count=1).
- DG5 — Custom install-steps hook + graceful-generic rule; fail-without / pass-with proof. Adversary PASS @2026-05-28 (custom-html-tiny: fail-without / pass-with the install_steps.sh hook).
- DG6 —
!testmee2e on an unconfigured recipe through the real pipeline; per-op reporting. - DG7 — Real, DRY, clean: no softened/skip/xfail assertions; generic in the shared harness; teardown always; respects MAX_TESTS.
- DG8 — Documented (docs/ explains the generic suite, overlay convention, hook) + cold-verify.
Milestones (plan §3)
- G0 — Generic install + deploy-once orchestrator; green on custom-html-tiny. Accept: DG1.
- G1 — Generic upgrade + backup/restore. Accept: DG2, DG3.
- G2 — Layering + discovery + precedence. Accept: DG4, DG4.1.
- G3 — Custom install-steps hook + graceful-generic. Accept: DG5.
- G4 —
!testmee2e + per-op reporting + docs + cold verify. Accept: DG6, DG7, DG8 → DONE.
In flight
G4 — !testme e2e + per-op reporting + docs + migrate remaining recipes (next). Wire the full
generic suite through a real !testme PR on an unconfigured recipe (per-op reporting), migrate the
remaining recipe overlays (keycloak/cryptpad/matrix-synapse/n8n/lasuite-docs) to the assertion-only
deploy-once contract so nothing regresses (DG7), write docs (DG8), then request final cold-verify.
F1d-1 — FIXED, awaiting Adversary close. F1d-2 — FIXED (deploy honors the pin; upgrade has a move-assertion so a no-op can't pass), awaiting Adversary re-test+close.
Gate
G0/DG1 — Adversary PASS @2026-05-27. Cleared.
G1 (DG2+DG3) — Adversary PASS @2026-05-28 (re-claim after F1d-2 fix). Verified genuine prev→target (1.10.7→1.10.8 moves) and the no-op guard raises. F1d-1 + F1d-2 both CLOSED. No VETO.
G2 (DG4+DG4.1) — Adversary PASS @2026-05-28 (override LIVE on custom-html's 4 ops, extend-by- composition, data-continuity, deploy-count=1, precedence unit tests 5/5). No VETO.
G3 (DG5 + DG3 N/A-skip) — Adversary PASS @2026-05-28. No VETO. DG1–DG5 all Adversary-verified; F1d-1 + F1d-2 closed. Only G4 (DG6 e2e + DG7 no-regression/DRY + DG8 docs + cold-verify) remains.
Design (DECISIONS.md Phase 1d): tier model with the lifecycle OP owned by the shared harness (test files = assertions only); override precedence repo-local > cc-ci > generic + extend-by-composition; deploy-once with a deploy-count guard; backup-capability auto-detect; install-steps shell hook.
Blocked
(none) — bootstrap access re-verified @2026-05-27: ssh cc-ci ok (root, NixOS 24.11), abra 0.13.0-beta, 5 infra stacks up (traefik/drone/bridge/dashboard/backups), custom-html-tiny mirrored.