Files
cc-ci/machine-docs/REVIEW-cfold.md
autonomic-bot 8fba68e27c
All checks were successful
continuous-integration/drone/push Build is passing
review(cfold): record cold pre-claim audit
2026-06-12 15:57:02 +00:00

49 lines
2.7 KiB
Markdown

# REVIEW — Adversary — phase cfold
Adversary-only. Append-only. All verdicts here are cold-verified from a fresh shell + own clone.
SSOT for what is being verified: /srv/cc-ci/cc-ci-plan/plan-phase-cfold-custom-folder.md
---
## 2026-06-11T22:54Z — Adversary initialized; awaiting Builder M1 claim
Baseline recorded in BACKLOG-cfold.md (pre-migration inventory).
No claims pending. Will verify M1 and M2 on Builder claim.
Key break-it probes planned:
1. Grep codebase for any remaining `functional/` or `playwright/` folder-name string literals after M1.
2. Run discovery cold to confirm no test was dropped (count must equal 64 custom test files).
3. Verify deprecated-alias warning fires when a test is in old folder (per plan §2.1 recommendation).
4. Confirm `from playwright.sync_api` references NOT touched (they reference the package, not a folder).
5. Verify unit tests are updated (test_discovery_phase2.py, test_manifest.py) and still pass.
6. Confirm manifest.py custom_counts changes correctly (sub will be "custom" not "functional"/"playwright").
7. Confirm RUNG name "functional" (L4) is NOT renamed — only the folder name changes.
8. M2: real Drone !testme sweep across all enrolled recipes — same level, same tests, zero leaks.
---
## 2026-06-12T00:00Z — No cfold gate claim visible; phase STATUS file missing
- Cold pull in `/srv/cc-ci/cc-ci-adv`: `git pull --rebase` -> `Already up to date.`
- `machine-docs/STATUS-cfold.md` is absent in the shared repo state, so there is no canonical cfold
gate claim / WHAT+HOW+EXPECTED+WHERE payload to verify per `plan.md` §6.1 and the phase kickoff.
- No `ADVERSARY-INBOX.md` present. No formal cfold claim pending.
- Action: notified Builder via `machine-docs/BUILDER-INBOX.md` to create/populate `STATUS-cfold.md`
before claiming M1 or M2.
---
## 2026-06-12T16:00Z — Cold audit: still no cfold claim; repo remains pre-migration
- Cold rebase in `/srv/cc-ci/cc-ci-adv`: `git pull --rebase` -> `Already up to date.`
- `machine-docs/STATUS-cfold.md` is still absent on `origin/main`; no formal M1/M2 WHAT+HOW+EXPECTED+WHERE
payload exists to verify.
- `git log --all --grep='cfold' --grep='custom/' --grep='functional/' --grep='playwright/'` shows no
Builder-side cfold implementation/claim commits yet; only the Adversary bootstrap/notice commits are
present for this phase.
- Cold tree audit still matches the pre-migration shape: custom tests remain under
`tests/<recipe>/functional/` and `tests/<recipe>/playwright/`, and docs/discovery/unit-test literals
still reference those folder names.
- Verdict: no gate claim pending; nothing to PASS/FAIL yet. Waiting for Builder to publish
`STATUS-cfold.md` and a formal M1 or M2 claim.