a10603638a
level=5/5 verified; 53/53 unit tests PASS (Adversary cold run from adv-clone); code review: all test hooks have teeth; dep path correct; LFS skip correct. One non-blocking finding: stale screenshot (pre-existing harness bug, manual run_id reuse).
42 lines
2.4 KiB
Markdown
42 lines
2.4 KiB
Markdown
# BACKLOG — phase gtea (gitea full-test enrollment)
|
|
|
|
## Build backlog
|
|
(Builder-owned — read-only to Adversary)
|
|
|
|
- [x] 0. Prerequisites verified (timezone, recipe, backup labels)
|
|
- [x] 1. Write all gitea test files (recipe_meta.py + ops.py + lifecycle overlays + custom + PARITY.md)
|
|
- [x] 2. Run harness locally against cc-ci (install + upgrade + backup + restore + custom) on gitea main
|
|
Run 846690: level=5/5 (all PASS). Fixes: _csrf→user_name selector; cred_url git push;
|
|
auto_init repo; token scopes for gitea 1.22+; NixOS git-lfs deploy.
|
|
- [x] 3. Confirm drone CI stays green (dep path unaffected by recipe_meta.py changes)
|
|
Unit tests pass (10/10 gitea dep + 43/43 meta). Drone dep path byte-for-byte unchanged.
|
|
- [x] 4. Verify LFS test correctly skips on main (compose.lfs.yml absent)
|
|
SKIPPED with expected message in run 846690. PASS.
|
|
- [ ] 5. CLAIM M1 (await Adversary PASS) ← CLAIMED, awaiting Adversary verdict
|
|
- [ ] 6. Run full harness via real CI / !testme on gitea recipe
|
|
- [ ] 7. Run harness on lfs-plain-gitea head → LFS test must go green
|
|
- [ ] 8. Post !testme on PR #1 so result lands in PR
|
|
- [ ] 9. CLAIM M2 (await Adversary PASS)
|
|
- [ ] 10. Write ## DONE (all Adversary PASSes)
|
|
|
|
## Adversary findings
|
|
(Adversary-owned — only the Adversary writes this section)
|
|
|
|
### [non-blocking] Stale screenshot in manual runs @2026-06-15T20:32Z
|
|
|
|
`/var/lib/cc-ci-runs/manual/screenshot.png` mtime = June 13, not from today's M1 run.
|
|
|
|
Root cause: `screenshot.capture()` (screenshot.py:149) checks `if not os.path.exists(out_path)`
|
|
after the SCREENSHOT hook runs. For run_id="manual", `out_path` reuses the same directory
|
|
(`/var/lib/cc-ci-runs/manual/screenshot.png`), so if a prior manual run left a file there, the
|
|
guard prevents overwriting it. The SCREENSHOT hook (recipe_meta.py) navigates to the login page
|
|
but doesn't call `page.screenshot()` itself — that's the harness's job, blocked by the guard.
|
|
|
|
Impact: results.json shows `"screenshot": "screenshot.png"` (file exists, non-empty) but the
|
|
image is from a prior session. Cosmetic only — does not affect verdict (R7).
|
|
M2 runs with DRONE_BUILD_NUMBER → unique dir → no issue.
|
|
|
|
Recommendation: `screenshot.capture()` should always overwrite (remove `if not exists` guard),
|
|
or the Builder could add `page.screenshot(path=out_path)` at the end of the SCREENSHOT hook.
|
|
No action required for M1/M2 gates. Pre-existing harness limitation, not Builder error.
|