26 lines
1.6 KiB
Markdown
26 lines
1.6 KiB
Markdown
# REVIEW — phase `prevb` (Adversary verdicts)
|
|
|
|
Append-only. Gates this phase: **M1** (implemented + green locally), **M2** (proven in real CI + spot-check).
|
|
SSOT: `/srv/cc-ci/cc-ci-plan/plan-phase-prevb-previous-dynamic-base.md`.
|
|
|
|
## Status
|
|
- 2026-06-16T23:57Z — Adversary live for `prevb`. No Builder claim yet (no STATUS-prevb.md, no `claim(`).
|
|
Cold-start recon done: baseline mechanism understood —
|
|
- base resolution: `run_recipe_ci.upgrade_base` → `meta.UPGRADE_BASE_VERSION or lifecycle.previous_version` (`vers[-2]`); discourse pins `0.7.0+3.3.1`.
|
|
- overlay `tests/discourse/compose.ccci.yml` applied to ALL deploys via `EXTRA_ENV.COMPOSE_FILE`; fuses environmental (start_period 20m, order stop-first) + version-specific (bitnamilegacy image pin + sidekiq block) — the bug.
|
|
- existing unit tests to watch for weakening: `tests/unit/test_upgrade_base.py`, `tests/unit/test_meta.py`.
|
|
Idle until a gate is CLAIMED.
|
|
- 2026-06-17T00:12Z — Independently cold-verified the Builder's STATUS ground-truth facts via gitea API
|
|
(NOT trusting STATUS): PR #4 head `ae5a81802b4d1d6cd1b449ac46cfa16d80730aaa` `compose.yml` →
|
|
`app.image = discourse/discourse:3.5.3`, **no `sidekiq` service**; `.diff` shows
|
|
`-bitnamilegacy/discourse:3.5.0`→`+discourse/discourse:3.5.3` + full `sidekiq:` block removed.
|
|
main → `app`+`sidekiq` = `bitnamilegacy/discourse:3.5.0`, sidekiq present, base `f87c612d`.
|
|
Facts CONFIRMED. (Caution noted: gitea `raw?ref=<shortsha>` silently falls back to default branch —
|
|
must use the FULL sha when cold-verifying head content.) Foundation for "discourse needs no previous/" holds.
|
|
|
|
## Verdicts
|
|
(none yet)
|
|
|
|
## Open VETOes
|
|
(none)
|