recipe-maintainers/custom-html
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

V5/V6 stale-test verification - custom-html docroot move (DO NOT MERGE) #3

Closed
autonomic-bot wants to merge 5 commits from v5-stale-docroot into main
pull from: v5-stale-docroot
merge into: recipe-maintainers:main
Conversation 11 Commits 5 Files Changed 3 +9 -2
autonomic-bot commented 2026-05-31 19:51:15 +00:00
Owner
Copy Link

Phase 5 verification PR for the stale-test path.

This branch intentionally moves the internal custom-html docroot from /usr/share/nginx/html to /var/www/html while keeping the app externally healthy. Existing cc-ci custom-html tests still hardcode the old in-container path, so this PR should demonstrate a genuine stale-test failure for V5/V6.

Verification only. DO NOT MERGE.

Phase 5 verification PR for the stale-test path. This branch intentionally moves the internal custom-html docroot from /usr/share/nginx/html to /var/www/html while keeping the app externally healthy. Existing cc-ci custom-html tests still hardcode the old in-container path, so this PR should demonstrate a genuine stale-test failure for V5/V6. Verification only. DO NOT MERGE.
autonomic-bot added 1 commit 2026-05-31 19:51:16 +00:00
feat: move custom-html docroot to /var/www/html
Some checks failed
cc-ci/testme cc-ci: failure
Details
fc2c80cfac
autonomic-bot commented 2026-05-31 19:51:19 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot commented 2026-05-31 19:51:37 +00:00
Author
Owner
Copy Link

🌻 cc-ci — custom-html @ 71e7326a ❌ failure

cc-ci result card

level

full logs · dashboard

<!-- cc-ci:testme --> 🌻 **cc-ci** — `custom-html` @ `71e7326a` ❌ **failure** [![cc-ci result card](https://ci.commoninternet.net/runs/81/summary.png)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/81) [![level](https://ci.commoninternet.net/runs/81/badge.svg)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/81) [full logs](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/81) · [dashboard](https://ci.commoninternet.net/)
autonomic-bot added 1 commit 2026-05-31 19:54:26 +00:00
fix: move docroot seed to /srv/www/html with config v7
Some checks failed
cc-ci/testme cc-ci: failure
Details
9802e61496
autonomic-bot commented 2026-05-31 19:57:08 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot commented 2026-06-01 19:41:22 +00:00
Author
Owner
Copy Link

The upgrade/sandbox change itself looks correct, but the current cc-ci tests are stale for this seeded verification case.

Observed on !testme build #40 for this PR:

  • install passed
  • upgrade passed
  • the app stayed externally healthy (HTTP 200, browser smoke passed)
  • failures are in cc-ci assertions that still hardcode the old in-container docroot /usr/share/nginx/html

Why this looks stale:

  • this PR intentionally moves the internal served/backup path from /usr/share/nginx/html to /srv/www/html while keeping the app externally healthy
  • the failing cc-ci tests/ops still write/read markers at the old path, so they fail for the seeded path change rather than for an externally broken app
  • examples from build #40:
    • tests/custom-html/test_backup.py -> cat: /usr/share/nginx/html/ci-marker.txt: No such file or directory
    • tests/custom-html/functional/test_content_roundtrip.py wrote the file to the old path, then got HTTP 404
    • tests/custom-html/functional/test_content_type_header.py likewise wrote to the old path and then hit HTTP 404

Default mode is leaving this recipe PR open with no cc-ci test edits.

If you want the cc-ci tests updated and verified against this seeded sandbox change, re-run:
/recipe-upgrade custom-html --with-tests

The upgrade/sandbox change itself looks correct, but the current cc-ci tests are stale for this seeded verification case. Observed on `!testme` build `#40` for this PR: - install passed - upgrade passed - the app stayed externally healthy (`HTTP 200`, browser smoke passed) - failures are in cc-ci assertions that still hardcode the old in-container docroot `/usr/share/nginx/html` Why this looks stale: - this PR intentionally moves the internal served/backup path from `/usr/share/nginx/html` to `/srv/www/html` while keeping the app externally healthy - the failing cc-ci tests/ops still write/read markers at the old path, so they fail for the seeded path change rather than for an externally broken app - examples from build `#40`: - `tests/custom-html/test_backup.py` -> `cat: /usr/share/nginx/html/ci-marker.txt: No such file or directory` - `tests/custom-html/functional/test_content_roundtrip.py` wrote the file to the old path, then got `HTTP 404` - `tests/custom-html/functional/test_content_type_header.py` likewise wrote to the old path and then hit `HTTP 404` Default mode is leaving this recipe PR open with no cc-ci test edits. If you want the cc-ci tests updated and verified against this seeded sandbox change, re-run: `/recipe-upgrade custom-html --with-tests`
autonomic-bot added 1 commit 2026-06-01 19:55:09 +00:00
fix: use /var/www/html for seeded docroot move
Some checks failed
cc-ci/testme cc-ci: failure
Details
194915b078
autonomic-bot commented 2026-06-01 19:55:57 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot added 1 commit 2026-06-01 20:01:01 +00:00
fix: seed stale mime assertion instead of docroot move
All checks were successful
cc-ci/testme cc-ci: success
Details
ee5cb811c6
autonomic-bot commented 2026-06-01 20:01:10 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot added 1 commit 2026-06-01 20:03:05 +00:00
fix: force octet-stream for seeded txt files
Some checks failed
cc-ci/testme cc-ci: failure
Details
71e7326a99
autonomic-bot commented 2026-06-01 20:03:13 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot commented 2026-06-01 20:07:11 +00:00
Author
Owner
Copy Link

Paired with cc-ci test PR: recipe-maintainers/cc-ci#3

This seeded Phase-5 sandbox branch intentionally changes .txt responses to application/octet-stream, which leaves the app healthy but makes the current cc-ci MIME assertion stale.

Cold branch-checkout verification with the paired cc-ci test branch is GREEN:
REMOTE_ROOT=/root/cc-ci-v6-custom-mime RECIPE=custom-html REF=v5-stale-docroot /srv/cc-ci-orch/.claude/skills/ci-test-review/verify-pr.sh
-> VERDICT: GREEN

Nothing merged.

Paired with cc-ci test PR: https://git.autonomic.zone/recipe-maintainers/cc-ci/pulls/3 This seeded Phase-5 sandbox branch intentionally changes `.txt` responses to `application/octet-stream`, which leaves the app healthy but makes the current cc-ci MIME assertion stale. Cold branch-checkout verification with the paired cc-ci test branch is GREEN: `REMOTE_ROOT=/root/cc-ci-v6-custom-mime RECIPE=custom-html REF=v5-stale-docroot /srv/cc-ci-orch/.claude/skills/ci-test-review/verify-pr.sh` -> `VERDICT: GREEN` Nothing merged.
autonomic-bot commented 2026-06-01 21:39:58 +00:00
Author
Owner
Copy Link

!testmexyz

!testmexyz
autonomic-bot commented 2026-06-01 21:41:17 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot commented 2026-06-01 21:43:01 +00:00
Author
Owner
Copy Link

cc-ci: upgrade looks correct — one test appears stale

!testme for custom-html v5-stale-docroot @ 71e7326a on build #81:

Stage Result
install ✅ pass
upgrade ✅ pass
backup ✅ pass
restore ✅ pass
custom (functional) ❌ fail

The upgrade itself looks correct — app deploys, upgrades cleanly, and backup/restore work.

Stale test identified: tests/custom-html/functional/test_content_type_header.py::test_content_type_html_and_txt

The test expects .txt files to be served with Content-Type: text/plain, but this version returns application/octet-stream for .txt files:

AssertionError: ccci-e0d6e804.txt Content-Type='application/octet-stream', expected text/plain

This is because the nginx configuration in this upgrade version overrides the default MIME type for .txt files (serving them as binary/octet-stream rather than text/plain). The test was written for the previous nginx behaviour and is now stale.

No test modifications were made. The cc-ci harness treats this as SUCCESS-PENDING-TESTS.

To also open a verified cc-ci test PR updating the stale assertion, re-run:

/recipe-upgrade custom-html --with-tests

(This will open a paired cc-ci test PR and verify the upgrade passes with the corrected test — all on dedicated branches, never merged automatically.)

## cc-ci: upgrade looks correct — one test appears stale `!testme` for **custom-html** `v5-stale-docroot` @ `71e7326a` on build [#81](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/81): | Stage | Result | |-------|--------| | install | ✅ pass | | upgrade | ✅ pass | | backup | ✅ pass | | restore | ✅ pass | | custom (functional) | ❌ fail | **The upgrade itself looks correct** — app deploys, upgrades cleanly, and backup/restore work. **Stale test identified:** `tests/custom-html/functional/test_content_type_header.py::test_content_type_html_and_txt` The test expects `.txt` files to be served with `Content-Type: text/plain`, but this version returns `application/octet-stream` for `.txt` files: ``` AssertionError: ccci-e0d6e804.txt Content-Type='application/octet-stream', expected text/plain ``` This is because the nginx configuration in this upgrade version overrides the default MIME type for `.txt` files (serving them as binary/octet-stream rather than text/plain). The test was written for the previous nginx behaviour and is now stale. **No test modifications were made.** The cc-ci harness treats this as `SUCCESS-PENDING-TESTS`. To also open a verified cc-ci test PR updating the stale assertion, re-run: ``` /recipe-upgrade custom-html --with-tests ``` (This will open a paired cc-ci test PR and verify the upgrade passes with the corrected test — all on dedicated branches, never merged automatically.)
autonomic-bot closed this pull request 2026-06-01 22:03:03 +00:00
Some checks failed
cc-ci/testme cc-ci: failure
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
autonomic autonomic-bot notplants trav
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: recipe-maintainers/custom-html#3
No description provided.
Delete Branch "v5-stale-docroot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?