chore: upgrade to 7.3.0+v1.154.0 #1
Reference in New Issue
Block a user
No description provided.
Delete Branch "upgrade-7.2.0+v1.153.0"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Recipe upgrade.
Commits on top of upstream main:
21e5d84chore: upgrade to 7.2.0+v1.153.0Tested green on the cc-ci recipe CI server (full suite, cold, against this PR head). NOT merged — for operator review.
cc @trav @notplants
!testme
cc-ci: run for
matrix-synapse@21e5d844✅ passed → https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/87!testme
!testme
cc-ci: run for
matrix-synapse@21e5d844❌ failure → https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/53The upgrade itself looks correct, but the current cc-ci upgrade assertion appears stale for this new recipe version.
Observed on
!testmebuild#53for this PR:tests/matrix-synapse/test_upgrade.py::test_upgrade_preserves_datafailedWhy this looks stale:
ci_markercreated bytests/matrix-synapse/ops.pyERROR: relation "ci_marker" does not existDefault mode is leaving the recipe PR open with no cc-ci test edits.
If you want the cc-ci test updated and verified against this upgraded recipe, re-run:
/recipe-upgrade matrix-synapse --with-tests!testme
🌻 cc-ci —
matrix-synapse@21e5d844❌ failurefull logs · dashboard
@notplants — flagging this open PR from the cc-ci build for your review. Per the updated mirror workflow we no longer auto-close superseded/unrelated PRs, so it's left open for you to merge or close at your discretion. (Heads-up: a fresh CI re-run of this upgrade recently went RED — worth a look before merge.)
!testme
Build #158 (fresh
!testmerun, same PR head21e5d844) is also RED on the same test:test_upgrade_reconverges: PASStest_upgrade_preserves_data: FAIL —ERROR: relation "ci_marker" does not existThis is the same stale-test failure diagnosed on build #53 (June 1). The upgrade itself is correct: synapse reconverges, serves
/_matrix/client/versions, and all functional checks pass. Theci_markertable written byops.pre_upgradeinto thesynapsepostgres database is not found after the pgautoupgrade 17→18 major version bump, which means the test assertion is not reliable in the presence of this major postgres upgrade.Note: build #87 (May 27) DID pass with the same code, so this is likely a timing/environment sensitivity in the test around the pg_upgrade operation, not a definitive recipe regression.
This upgrade (synapse v1.149.1 → v1.153.0, pgautoupgrade 17→18, nginx 1.29.6 → 1.31.1, mas 1.14.0 → 1.17.0) appears correct. The
test_upgrade_preserves_datatest needs updating for the postgres major-version upgrade scenario.To open + verify a cc-ci test PR alongside this recipe PR, re-run:
/recipe-upgrade matrix-synapse --with-testschore: upgrade to 7.2.0+v1.153.0to chore: upgrade to 7.3.0+v1.154.0!testme
🌻 cc-ci —
matrix-synapse@f68d9a65✅ passedfull logs · dashboard
f68d9a655etoc1fa09a2ec!testme
🌻 cc-ci —
matrix-synapse@c1fa09a2❌ failurefull logs · dashboard
!testme
🌻 cc-ci —
matrix-synapse@ebfaf901✅ passedfull logs · dashboard
ebfaf90164toc94186132c!testme
🌻 cc-ci —
matrix-synapse@c9418613✅ passedfull logs · dashboard
Pull request closed