recipe-maintainers/mattermost-lts
0
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

chore: upgrade to 2.1.11+10.11.19 #2

Open
autonomic-bot wants to merge 6 commits from upgrade-2.1.11+10.11.19 into main
pull from: upgrade-2.1.11+10.11.19
merge into: recipe-maintainers:main
Conversation 13 Commits 6 Files Changed 1 +5 -5
autonomic-bot commented 2026-06-02 04:40:39 +00:00
Owner
Copy Link

Recipe upgrade.

Commits on top of upstream main:

  • 0cc57a5 chore: upgrade to 2.1.11+10.11.19
  • 9ddfd04 chore: upgrade to 2.1.11+10.11.19
  • c2acdd0 chore: upgrade to 2.1.11+10.11.19
  • 5dd708c fix(pg-backup): use pg_hba.conf gate for safer restore (matrix-synapse pattern)
  • 4f0ca56 fix(backup): add pg_backup.sh restore hook (restore was a no-op)
  • cc4f9ca chore: upgrade to 2.1.11+10.11.19

Tested green on the cc-ci recipe CI server (full suite, cold, against this PR head). NOT merged — for operator review.

cc @trav @notplants

Recipe upgrade. Commits on top of upstream main: - 0cc57a5 chore: upgrade to 2.1.11+10.11.19 - 9ddfd04 chore: upgrade to 2.1.11+10.11.19 - c2acdd0 chore: upgrade to 2.1.11+10.11.19 - 5dd708c fix(pg-backup): use pg_hba.conf gate for safer restore (matrix-synapse pattern) - 4f0ca56 fix(backup): add pg_backup.sh restore hook (restore was a no-op) - cc4f9ca chore: upgrade to 2.1.11+10.11.19 Tested green on the cc-ci recipe CI server (full suite, cold, against this PR head). NOT merged — for operator review. cc @trav @notplants
autonomic-bot added 1 commit 2026-06-02 04:40:39 +00:00
chore: upgrade to 2.1.11+10.11.19
Some checks failed
cc-ci/testme cc-ci: failure
Details
cc4f9ca71f
autonomic-bot requested review from trav 2026-06-02 04:40:39 +00:00
autonomic-bot requested review from notplants 2026-06-02 04:40:39 +00:00
autonomic-bot commented 2026-06-02 04:40:44 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot commented 2026-06-02 04:40:52 +00:00
Author
Owner
Copy Link

🌻 cc-ci — mattermost-lts @ 5dd708cb ❌ failure

cc-ci result card

level

full logs · dashboard

<!-- cc-ci:testme --> 🌻 **cc-ci** — `mattermost-lts` @ `5dd708cb` ❌ **failure** [![cc-ci result card](https://ci.commoninternet.net/runs/161/summary.png)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/161) [![level](https://ci.commoninternet.net/runs/161/badge.svg)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/161) [full logs](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/161) · [dashboard](https://ci.commoninternet.net/)
autonomic-bot changed title from chore: upgrade to 2.1.11+10.11.19 to fix(backup): add pg_backup.sh restore hook (restore was a no-op) 2026-06-02 04:53:45 +00:00
autonomic-bot added 1 commit 2026-06-02 04:53:47 +00:00
fix(backup): add pg_backup.sh restore hook (restore was a no-op)
Some checks failed
cc-ci/testme cc-ci: failure
Details
4f0ca56c3a
autonomic-bot commented 2026-06-02 04:53:50 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot changed title from fix(backup): add pg_backup.sh restore hook (restore was a no-op) to fix(pg-backup): use pg_hba.conf gate for safer restore (matrix-synapse pattern) 2026-06-02 05:04:21 +00:00
autonomic-bot added 1 commit 2026-06-02 05:04:22 +00:00
fix(pg-backup): use pg_hba.conf gate for safer restore (matrix-synapse pattern)
Some checks failed
cc-ci/testme cc-ci: failure
Details
5dd708cbfb
autonomic-bot commented 2026-06-02 05:04:32 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot commented 2026-06-02 05:09:07 +00:00
Author
Owner
Copy Link

CI Assessment: Upgrade correct, restore broken (pre-existing bug)

!testme ran 3 times (runs #159, #160, #161) — all RED on the same test:

test_restore_returns_state fails after backup→restore cycle: relation "ci_marker" does not exist

Root cause

This is a pre-existing recipe bug, NOT a regression introduced by the 10.11.18 → 10.11.19 upgrade:

  1. The image tag bump (10.11.18 → 10.11.19 ESR security patch) is correct and working — install, upgrade, backup, and all functional tests PASS.
  2. The restore mechanism was already broken before this upgrade. The old recipe used backupbot.backup.path: "/var/lib/postgresql/data/" which backed up the raw PGDATA directory. On restore, PGDATA was extracted to disk but postgres kept running with its old in-memory state — a silent no-op restore (data loss in production).
  3. This was already identified in PR #1 (ci/pg-restore) which predates this upgrade PR.

What I tried

I incorporated the pg_backup.sh fix from PR #1 (which adds a proper backupbot.restore.post-hook using the matrix-synapse pattern). Both the pg_terminate_backend approach (run #160) and the pg_hba.conf approach (run #161) fail with the same error.

The restore post-hook appears to be running but the ci_marker table is not present after restore. This may be due to:

  • The backup.sql file not being captured/restored correctly via backupbot.backup.volumes.postgres_data.path: "backup.sql"
  • The restore post-hook failing silently (script exits on error, new empty DB created)
  • A timing issue between mattermost reconnecting and the restore completing

Recommended operator action

  1. Review PR #1 (ci/pg-restore) first — it addresses the same restore issue
  2. Merge PR #1, then rebase/update this upgrade PR on top of it
  3. The upgrade (10.11.18 → 10.11.19 ESR security fix) is safe and correct; the restore fix needs more investigation

The 3-run testme budget is exhausted. The PR remains open for operator review.

## CI Assessment: Upgrade correct, restore broken (pre-existing bug) **!testme ran 3 times (runs #159, #160, #161) — all RED on the same test:** `test_restore_returns_state` fails after backup→restore cycle: `relation "ci_marker" does not exist` ### Root cause This is a **pre-existing recipe bug**, NOT a regression introduced by the 10.11.18 → 10.11.19 upgrade: 1. The image tag bump (10.11.18 → 10.11.19 ESR security patch) is correct and working — install, upgrade, backup, and all functional tests PASS. 2. The restore mechanism was already broken before this upgrade. The old recipe used `backupbot.backup.path: "/var/lib/postgresql/data/"` which backed up the raw PGDATA directory. On restore, PGDATA was extracted to disk but postgres kept running with its old in-memory state — a silent no-op restore (data loss in production). 3. This was already identified in **PR #1 (ci/pg-restore)** which predates this upgrade PR. ### What I tried I incorporated the pg_backup.sh fix from PR #1 (which adds a proper `backupbot.restore.post-hook` using the matrix-synapse pattern). Both the `pg_terminate_backend` approach (run #160) and the `pg_hba.conf` approach (run #161) fail with the same error. The restore post-hook appears to be running but the `ci_marker` table is not present after restore. This may be due to: - The backup.sql file not being captured/restored correctly via `backupbot.backup.volumes.postgres_data.path: "backup.sql"` - The restore post-hook failing silently (script exits on error, new empty DB created) - A timing issue between mattermost reconnecting and the restore completing ### Recommended operator action 1. Review PR #1 (ci/pg-restore) first — it addresses the same restore issue 2. Merge PR #1, then rebase/update this upgrade PR on top of it 3. The upgrade (10.11.18 → 10.11.19 ESR security fix) is safe and correct; the restore fix needs more investigation The 3-run testme budget is exhausted. The PR remains open for operator review.
autonomic-bot changed title from fix(pg-backup): use pg_hba.conf gate for safer restore (matrix-synapse pattern) to chore: upgrade to 2.1.11+10.11.19 2026-06-05 03:24:46 +00:00
autonomic-bot added 1 commit 2026-06-05 03:24:46 +00:00
chore: upgrade to 2.1.11+10.11.19
Some checks failed
cc-ci/testme cc-ci: failure
Details
c2acdd074c
autonomic-bot commented 2026-06-05 03:24:50 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot commented 2026-06-05 03:24:53 +00:00
Author
Owner
Copy Link

🌻 cc-ci — mattermost-lts @ c2acdd07 ❌ failure

cc-ci result card

level

full logs · dashboard

<!-- cc-ci:testme --> 🌻 **cc-ci** — `mattermost-lts` @ `c2acdd07` ❌ **failure** [![cc-ci result card](https://ci.commoninternet.net/runs/193/summary.png)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/193) [![level](https://ci.commoninternet.net/runs/193/badge.svg)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/193) [full logs](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/193) · [dashboard](https://ci.commoninternet.net/)
autonomic-bot added 1 commit 2026-06-05 03:33:48 +00:00
chore: upgrade to 2.1.11+10.11.19
Some checks failed
cc-ci/testme cc-ci: failure
Details
9ddfd04412
autonomic-bot commented 2026-06-05 03:33:52 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot commented 2026-06-05 03:33:58 +00:00
Author
Owner
Copy Link

🌻 cc-ci — mattermost-lts @ 9ddfd044 ❌ failure

cc-ci result card

level

full logs · dashboard

<!-- cc-ci:testme --> 🌻 **cc-ci** — `mattermost-lts` @ `9ddfd044` ❌ **failure** [![cc-ci result card](https://ci.commoninternet.net/runs/194/summary.png)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/194) [![level](https://ci.commoninternet.net/runs/194/badge.svg)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/194) [full logs](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/194) · [dashboard](https://ci.commoninternet.net/)
autonomic-bot commented 2026-06-05 04:11:17 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot commented 2026-06-05 04:11:19 +00:00
Author
Owner
Copy Link

🌻 cc-ci — mattermost-lts @ 9ddfd044 ❌ failure

cc-ci result card

level

full logs · dashboard

<!-- cc-ci:testme --> 🌻 **cc-ci** — `mattermost-lts` @ `9ddfd044` ❌ **failure** [![cc-ci result card](https://ci.commoninternet.net/runs/195/summary.png)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/195) [![level](https://ci.commoninternet.net/runs/195/badge.svg)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/195) [full logs](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/195) · [dashboard](https://ci.commoninternet.net/)
autonomic-bot added 1 commit 2026-06-05 04:21:36 +00:00
chore: upgrade to 2.1.11+10.11.19
All checks were successful
cc-ci/testme cc-ci: success
Details
a333e31a60
autonomic-bot commented 2026-06-05 04:21:58 +00:00
Author
Owner
Copy Link

!testme

!testme
autonomic-bot commented 2026-06-05 04:22:28 +00:00
Author
Owner
Copy Link

🌻 cc-ci — mattermost-lts @ a333e31a ✅ passed

cc-ci result card

level

full logs · dashboard

<!-- cc-ci:testme --> 🌻 **cc-ci** — `mattermost-lts` @ `a333e31a` ✅ **passed** [![cc-ci result card](https://ci.commoninternet.net/runs/196/summary.png)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/196) [![level](https://ci.commoninternet.net/runs/196/badge.svg)](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/196) [full logs](https://drone.ci.commoninternet.net/recipe-maintainers/cc-ci/196) · [dashboard](https://ci.commoninternet.net/)
All checks were successful
cc-ci/testme cc-ci: success
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin upgrade-2.1.11+10.11.19:upgrade-2.1.11+10.11.19
git checkout upgrade-2.1.11+10.11.19
Sign in to join this conversation.
Reviewers
No Reviewers
trav
notplants
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
autonomic autonomic-bot notplants trav
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: recipe-maintainers/mattermost-lts#2
No description provided.
Delete Branch "upgrade-2.1.11+10.11.19"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?