ruangrupa/konfluks
ruangrupa/konfluks
2
0
Fork 2
Code Issues 9 Pull Requests Projects Releases Wiki Activity

[video.py] find a way to create human readable file names #14

New Issue
Closed
opened 2022-01-09 20:03:53 +00:00 by r · 6 comments
r commented 2022-01-09 20:03:53 +00:00
Member
Copy Link

Same as #10

currently the data follows /path/to/content/UUID/ as naming format for blog posts.

Would /path/to/content/video-title--UUID/ be better?

Same as #10 currently the data follows `/path/to/content/UUID/` as naming format for blog posts. Would `/path/to/content/video-title--UUID/` be better?
knoflook commented 2022-02-03 15:09:39 +00:00
Owner
Copy Link

closed in 77b8c9e0af

closed in 77b8c9e0af
r commented 2022-02-04 08:41:45 +00:00
Author
Member
Copy Link

Hi,

Thank you!

This patch doesn't take in to account the check to see whether a file needs to be deleted which is based on the filename:

See 77b8c9e0af/lumbunglib/video.py (L119)

and 77b8c9e0af/lumbunglib/video.py (L125)

It checks for the existence of UUID but you write a file which is Name+UUID: 77b8c9e0af/lumbunglib/video.py (L122)

Possibly the same in ruangrupa/lumbunglib#10

Hi, Thank you! This patch doesn't take in to account the check to see whether a file needs to be deleted which is based on the filename: See https://git.autonomic.zone/ruangrupa/lumbunglib/src/commit/77b8c9e0af2c2fd8f28b9c496450b9e776fdb0f8/lumbunglib/video.py#L119 and https://git.autonomic.zone/ruangrupa/lumbunglib/src/commit/77b8c9e0af2c2fd8f28b9c496450b9e776fdb0f8/lumbunglib/video.py#L125 It checks for the existence of UUID but you write a file which is Name+UUID: https://git.autonomic.zone/ruangrupa/lumbunglib/src/commit/77b8c9e0af2c2fd8f28b9c496450b9e776fdb0f8/lumbunglib/video.py#L122 Possibly the same in https://git.autonomic.zone/ruangrupa/lumbunglib/issues/10
knoflook reopened this issue 2022-02-07 10:30:49 +00:00
knoflook commented 2022-02-07 10:31:57 +00:00
Owner
Copy Link

This patch doesn't take in to account the check to see whether a file needs to be deleted which is based on the filename

you're right, thanks for pointing this out!

> This patch doesn't take in to account the check to see whether a file needs to be deleted which is based on the filename you're right, thanks for pointing this out!
knoflook commented 2022-02-07 10:51:33 +00:00
Owner
Copy Link

fixed in 58024c775a

fixed in 58024c775a
r commented 2022-02-08 17:43:40 +00:00
Author
Member
Copy Link

Thanks! More things coming up out of this. Maybe you already saw in nongkrong but the links are broken.

https://lumbung.space/tv/lumbung%20konteks-%20Listening%20to%20The%20Land-%20-4df9e52b-bcbc-41a7-a986-2463464db6e5/d96aeed2-4ea3-409e-b60e-69af5c1f402f.jpg

Probably because of the whitespaces in the title. Rather than using self-rolled sanitization logic: in the other scripts I've relied on slugify to make the post names. It strips much more, but is also multilingual etc and is already a dependency for this repo.

edit: perhaps related? ruangrupa/lumbung.space#31

Thanks! More things coming up out of this. Maybe you already saw in nongkrong but the links are broken. https://lumbung.space/tv/lumbung%20konteks-%20Listening%20to%20The%20Land-%20-4df9e52b-bcbc-41a7-a986-2463464db6e5/d96aeed2-4ea3-409e-b60e-69af5c1f402f.jpg Probably because of the whitespaces in the title. Rather than using self-rolled sanitization logic: in the other scripts I've relied on [slugify](https://https://git.autonomic.zone/ruangrupa/lumbunglib/src/branch/master/lumbunglib/feed.py#L241) to make the post names. It strips much more, but is also multilingual etc and is already a dependency for this repo. edit: perhaps related? https://git.autonomic.zone/ruangrupa/lumbung.space/issues/31
decentral1se commented 2022-02-10 12:00:58 +00:00
Owner
Copy Link

fixed (we hope 🙏) 34d84dcde2

fixed (we hope 🙏) https://git.autonomic.zone/ruangrupa/lumbunglib/commit/34d84dcde2247620811bcedb12867f9bffbae6ec
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ruangrupa/konfluks#14
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?