ruangrupa/konfluks
ruangrupa/konfluks
2
0
Fork 2
Code Issues 9 Pull Requests Projects Releases Wiki Activity

Support OPDS feeds, sanitize yaml frontmatter & relicense to AGPL #26

Closed
r wants to merge 0 commits from master into master
pull from: master
merge into: ruangrupa:master
Conversation 4 Commits - Files Changed -
r commented 2022-02-16 14:01:42 +00:00
Member
Copy Link
No description provided.
r added 3 commits 2022-02-16 14:01:43 +00:00
knoflook commented 2022-02-17 15:31:11 +00:00
Owner
Copy Link

I introduced a merge conflict while doing a hotfix on feed.py to escape ". I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!

I introduced a merge conflict while doing a hotfix on `feed.py` to escape `"`. I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!
r commented 2022-02-17 17:02:40 +00:00
Author
Member
Copy Link

I introduced a merge conflict while doing a hotfix on feed.py to escape ". I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!

Yes I saw how you resolved it in the hashtag feed and thought to generalize it as a method because the quotes can happen in a lot of places.

We could even split it off to a separate util script so the method can be imported by the other scripts?

There might be one or two other things that could go to such a util script. However, while there is a lot that the scripts do very very similarly, it tends to be not similar enough, to make a general method. It is also why I rolled OPDS in to the feed.py..

> I introduced a merge conflict while doing a hotfix on `feed.py` to escape `"`. I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it! Yes I saw how you resolved it in the hashtag feed and thought to generalize it as a method because the quotes can happen in a lot of places. We could even split it off to a separate util script so the method can be imported by the other scripts? There might be one or two other things that could go to such a util script. However, while there is a lot that the scripts do very very similarly, it tends to be not similar enough, to make a general method. It is also why I rolled OPDS in to the feed.py..
knoflook commented 2022-02-21 10:16:34 +00:00
Owner
Copy Link

We could even split it off to a separate util script so the method can be imported by the other scripts?

I think it can stay as-is, I'm making one small change to the code to improve performance.

> We could even split it off to a separate util script so the method can be imported by the other scripts? I think it can stay as-is, I'm making one small change to the code to improve performance.
r added 2 commits 2022-03-03 05:54:54 +00:00 
Reviewed-on: r/lumbunglib#1
knoflook self-assigned this 2022-03-04 10:16:17 +00:00
knoflook changed title from WIP: Support OPDS feeds, sanitize yaml frontmatter & relicense to AGPL to Support OPDS feeds, sanitize yaml frontmatter & relicense to AGPL 2022-03-04 14:50:05 +00:00
knoflook commented 2022-03-04 14:50:43 +00:00
Owner
Copy Link

conflict resolved 😎

conflict resolved 😎
knoflook closed this pull request 2022-03-04 14:50:43 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
knoflook
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ruangrupa/konfluks#26
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?