I introduced a merge conflict while doing a hotfix on feed.py to escape ". I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!
I introduced a merge conflict while doing a hotfix on `feed.py` to escape `"`. I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!
I introduced a merge conflict while doing a hotfix on feed.py to escape ". I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!
Yes I saw how you resolved it in the hashtag feed and thought to generalize it as a method because the quotes can happen in a lot of places.
We could even split it off to a separate util script so the method can be imported by the other scripts?
There might be one or two other things that could go to such a util script. However, while there is a lot that the scripts do very very similarly, it tends to be not similar enough, to make a general method. It is also why I rolled OPDS in to the feed.py..
> I introduced a merge conflict while doing a hotfix on `feed.py` to escape `"`. I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!
Yes I saw how you resolved it in the hashtag feed and thought to generalize it as a method because the quotes can happen in a lot of places.
We could even split it off to a separate util script so the method can be imported by the other scripts?
There might be one or two other things that could go to such a util script. However, while there is a lot that the scripts do very very similarly, it tends to be not similar enough, to make a general method. It is also why I rolled OPDS in to the feed.py..
We could even split it off to a separate util script so the method can be imported by the other scripts?
I think it can stay as-is, I'm making one small change to the code to improve performance.
> We could even split it off to a separate util script so the method can be imported by the other scripts?
I think it can stay as-is, I'm making one small change to the code to improve performance.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
I introduced a merge conflict while doing a hotfix on
feed.pyto escape". I see you've done the same thing but 10 times better. I'll take a look at that PR tomorrow and fix it!Yes I saw how you resolved it in the hashtag feed and thought to generalize it as a method because the quotes can happen in a lot of places.
We could even split it off to a separate util script so the method can be imported by the other scripts?
There might be one or two other things that could go to such a util script. However, while there is a lot that the scripts do very very similarly, it tends to be not similar enough, to make a general method. It is also why I rolled OPDS in to the feed.py..
I think it can stay as-is, I'm making one small change to the code to improve performance.
conflict resolved 😎
Pull request closed