ruangrupa/lumbung.space
ruangrupa/lumbung.space
1
0
Fork 1
Code Issues 11 Pull Requests Projects Releases Wiki Activity

ruangrupa.id category cards are missing images/video on preview #32

New Issue
Closed
opened 2022-02-10 12:03:02 +00:00 by decentral1se · 2 comments
decentral1se commented 2022-02-10 12:03:02 +00:00
Owner
Copy Link

e.g. https://lumbung.space/shouts/ruangrupa.id/pameran-tunggal-abi-rama-drawing-drawings/ but the preview on https://lumbung.space/categories/ruangrupa.id/ doesn't show. We think this has to do with the way ruangrupa.id site generates the html that we embed and we're not sure what to do about that.

e.g. https://lumbung.space/shouts/ruangrupa.id/pameran-tunggal-abi-rama-drawing-drawings/ but the preview on https://lumbung.space/categories/ruangrupa.id/ doesn't show. We think this has to do with the way ruangrupa.id site generates the html that we embed and we're not sure what to do about that.
r commented 2022-02-11 06:25:28 +00:00
Member
Copy Link

The image is parsed and downloaded properly.

https://lumbung.space/shouts/ruangrupa.id/pameran-tunggal-abi-rama-drawing-drawings/Poster-Eflyer-Pameran-Abi-Rama.jpg

The issue is that the CSS does not show it. I've added some logic to the template which checks whether the image in in portrait or landscape mode and to shifts the layout accordingly (https://git.autonomic.zone/ruangrupa/lumbung.space/src/branch/main/themes/lumbung-theme/layouts/partials/network_card.html#L15).

This is apparently broken in the new redesign.

The image is parsed and downloaded properly. https://lumbung.space/shouts/ruangrupa.id/pameran-tunggal-abi-rama-drawing-drawings/Poster-Eflyer-Pameran-Abi-Rama.jpg The issue is that the CSS does not show it. I've added some logic to the template which checks whether the image in in portrait or landscape mode and to shifts the layout accordingly (https://git.autonomic.zone/ruangrupa/lumbung.space/src/branch/main/themes/lumbung-theme/layouts/partials/network_card.html#L15). This is apparently broken in the new redesign. ![](https://i.ibb.co/TKsrTqz/Screenshot-from-2022-02-11-07-20-01.png)
decentral1se added this to the (deleted) project 2022-02-11 10:32:22 +00:00
aadil self-assigned this 2022-03-11 11:18:32 +00:00
aadil commented 2022-04-12 21:04:55 +00:00
Owner
Copy Link

fixed with 3862d61741

fixed with https://git.autonomic.zone/ruangrupa/lumbung.space/commit/3862d61741afc6b0ed616198e7c44a54f4225c9c
aadil closed this issue 2022-04-12 21:05:03 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
aadil
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ruangrupa/lumbung.space#32
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?