Add tight rate-limit for API deletions (#10042)
Deletions take a lot of resources to execute and cause a lot of federation traffic, so it makes sense to decrease the number someone can queue up through the API. 30 per 30 minutes
This commit is contained in:
		| @ -46,14 +46,14 @@ class Rack::Attack | ||||
|   end | ||||
|  | ||||
|   throttle('throttle_authenticated_api', limit: 300, period: 5.minutes) do |req| | ||||
|     req.api_request? && req.authenticated_user_id | ||||
|     req.authenticated_user_id if req.api_request? | ||||
|   end | ||||
|  | ||||
|   throttle('throttle_unauthenticated_api', limit: 7_500, period: 5.minutes) do |req| | ||||
|     req.ip if req.api_request? | ||||
|   end | ||||
|  | ||||
|   throttle('throttle_media', limit: 30, period: 30.minutes) do |req| | ||||
|   throttle('throttle_api_media', limit: 30, period: 30.minutes) do |req| | ||||
|     req.authenticated_user_id if req.post? && req.path.start_with?('/api/v1/media') | ||||
|   end | ||||
|  | ||||
| @ -61,6 +61,13 @@ class Rack::Attack | ||||
|     req.ip if req.post? && req.path == '/api/v1/accounts' | ||||
|   end | ||||
|  | ||||
|   API_DELETE_REBLOG_REGEX = /\A\/api\/v1\/statuses\/[\d]+\/unreblog/.freeze | ||||
|   API_DELETE_STATUS_REGEX = /\A\/api\/v1\/statuses\/[\d]+/.freeze | ||||
|  | ||||
|   throttle('throttle_api_delete', limit: 30, period: 30.minutes) do |req| | ||||
|     req.authenticated_user_id if (req.post? && req.path =~ API_DELETE_REBLOG_REGEX) || (req.delete? && req.path =~ API_DELETE_STATUS_REGEX) | ||||
|   end | ||||
|  | ||||
|   throttle('protected_paths', limit: 25, period: 5.minutes) do |req| | ||||
|     req.ip if req.post? && req.path =~ PROTECTED_PATHS_REGEX | ||||
|   end | ||||
|  | ||||
		Reference in New Issue
	
	Block a user