Commit Graph
41 Commits
Author SHA1 Message Date
alpaca-tcandEugen Rochko 1fc6cb4997 Do not call setState from unmounted component (#3853)
Stop an executing task if the component already unmounted.
2017-06-20 20:37:09 +02:00
alpaca-tcandEugen Rochko cf6fe4f8cb Unobserve status on unmount (#3851) 2017-06-19 11:29:57 +02:00
alpaca-tcandEugen Rochko 8d2b3ada80 Fixes streaming callbacks of HashtagTimeline (#3849) 2017-06-19 10:28:35 +02:00
alpaca-tcandEugen Rochko 3652a39de0 Account.find_remote should be raise ActiveRecord::RecordNotFound (#3476) 2017-05-31 15:10:26 +02:00
alpaca-tcandEugen Rochko 08dce5e607 Refactor Setting (#3302)
* @object is not needed

* Remove unneeded dependencies

* Do not call private method

* Prefer #respond_to_missing? over #respond_to?

`#respond_to?` doesn't support `User.settings.method(:method_name)`

* Use find_or_initialize_by instead of
2017-05-25 14:14:36 +02:00
alpaca-tcandEugen Rochko 7ee5fc5d68 Toggle sensitive from admin page (#3261) 2017-05-23 19:45:43 +02:00
alpaca-tcandEugen Rochko 198ae3e366 Define instance method outside #included (#3128) 2017-05-19 11:41:45 +02:00
alpaca-tcandEugen Rochko 59ceeae8ea Refactor Status#ancestors/descendants (#3092) 2017-05-17 15:38:16 +02:00
alpaca-tcandEugen Rochko b397f69633 Render translated view (#3093) 2017-05-17 15:36:56 +02:00
alpaca-tcandEugen Rochko e89e4355eb Add filter to AccountFilter (#2968) 2017-05-17 03:00:34 +02:00
alpaca-tcandEugen Rochko 682b68438e Improve Account#triadic_closures (#3079) 2017-05-16 12:06:38 +02:00
alpaca-tcandEugen Rochko 09ec6e504b Order by symbol value (#3077) 2017-05-16 03:35:17 +02:00
alpaca-tcandEugen Rochko a2a2af244c Optimize Status#permitted_for 24x (#3069)
* Build query with arel node

* Add spec for current Status#permitted_for implementation

* Refactor status.rb

* Order by visibility to optimize query
2017-05-16 02:54:17 +02:00
alpaca-tcandEugen Rochko e9810cbad6 Fixes NoMethodError: undefined method 'first' for nil:NilClass (#3036) 2017-05-13 15:56:12 +02:00
alpaca-tcandEugen Rochko c3ef5d5414 Add account_id DESC to optimize PrecomputeFeedService (#2967) 2017-05-10 20:33:32 +02:00
alpaca-tcandEugen Rochko ef226a6f22 Remove rails_12factor (#2901) 2017-05-09 05:15:54 +02:00
alpaca-tcandEugen Rochko 8c9aff0bef Render sidekiq scheduler (#2898) 2017-05-08 03:52:57 +02:00
alpaca-tcandEugen Rochko d3704fdb09 Add effective index to subscriptions (#2885) 2017-05-07 19:00:20 +02:00
alpaca-tcandEugen Rochko ca05bfaac7 Refactor account.rb (#2881)
* Call simple query

* Refactor Account#keypair

* Replace escaped single quote

* Extract similar behavior to method

* Gather the same condition to one block

* Remove not needed receiver
2017-05-07 16:40:57 +02:00
alpaca-tcandEugen Rochko 74036a2c9d Hotfix convert string from symbol (#2856)
* Convert key to string from symbol

* Prefer :public_send instead of
2017-05-06 23:06:52 +02:00
alpaca-tcandEugen Rochko 05b72368ed Fixes slow query in notifications api (#2851)
* Add inclusion validation for activity_type

* When excluding all types with `WHERE NOT IN`, the query search all rows.
2017-05-06 21:55:40 +02:00
alpaca-tcandEugen Rochko a0b1951791 Refactor domain_blocks_controller (#2843)
* Set domain_block by before_action

* Cast value with ActiveRecord::Type

* Batch update
2017-05-06 17:03:34 +02:00
alpaca-tcandEugen Rochko 59804abc3d Optimize MuteService and AfterBlockService (#2836) 2017-05-06 16:31:07 +02:00
alpaca-tcandEugen Rochko 1f15a15621 Handling failed http response (#2823) 2017-05-06 12:55:59 +02:00
alpaca-tcandEugen Rochko ddc34feb58 Optimize follower_accounts and following_accounts (#2820) 2017-05-06 04:03:07 +02:00
alpaca-tcandEugen Rochko ee3e0a93f4 Fixes unknown mime type (#2822) 2017-05-05 21:32:14 +02:00
alpaca-tcandEugen Rochko d1290fbd8f Fixes propTypes warning introduced by #2774 (#2824) 2017-05-05 21:31:20 +02:00
alpaca-tcandEugen Rochko 74c8ca699c Delete records in smaller transaction (#2802) 2017-05-04 23:44:39 +02:00
alpaca-tcandEugen Rochko db92eec876 Localize 'throttled' (#2755) 2017-05-03 23:36:19 +02:00
alpaca-tcandEugen Rochko 96c84da1d4 Expand uploaded thumbnail (#2611) 2017-04-29 14:29:13 +02:00
alpaca-tcandEugen Rochko 7d36a76180 Remove uneeded ORDER BY query (#2615) 2017-04-29 10:50:10 +02:00
alpaca-tcandEugen Rochko 9317ec8eb1 Localize with i18n for Devise::FailureApp (#2309)
This PR fixes I18n.locale for rake middlewares. Mastodon uses Devise that depends on Warden.
Warden::Manager can be found in rake middleware. It is outside of the controller.

In the case of authentication failed, warden calls throw(:warden). At the time Warden::Manager
delegates request to failure_app to generate response and flash[:alert] after catching it.
Unfortunately, I18n.locale is already reset then because I18n.with_locale is enabled only
inside the controller. If we used I18n.locale=, Devise::FailureApp could get the current locale.
2017-04-25 15:06:41 +02:00
alpaca-tcandEugen d000a0b58a Add index to statuses_tags#status_id (#2394) 2017-04-24 15:10:14 +02:00
alpaca-tcandEugen 2c0d756ad9 Extract error messages to locale file (#2162) 2017-04-19 22:19:32 +02:00
alpaca-tcandEugen 5ce8a1811a Replace User.count -> User.confirmed.count (#2127) 2017-04-19 14:58:27 +02:00
alpaca-tcandEugen 630de52fdd Required foreign keys (#2003)
* Add `required: true` option to foreign column

* Fixes NoMethodError

```
> Favourite.new.valid?
NoMethodError: undefined method `reblog?' for nil:NilClass
```
2017-04-17 15:54:33 +02:00
alpaca-tcandEugen 19f63ff801 Check @recipient.user at the first (#1939) 2017-04-16 18:04:05 +02:00
alpaca-tcandEugen de72db99fa Add presence validation to Import (#1928)
```
*An* `ActiveRecord::StatementInvalid` *occurred while* `POST </settings/import>` *was processed by* `imports#create`
Exception
----------------
PG::NotNullViolation: ERROR:  null value in column "type" violates not-null constraint
```
2017-04-16 16:28:26 +02:00
alpaca-tcandEugen 8f8319852c Fixed NoMethodError in UnfollowService (#1918) 2017-04-16 14:55:43 +02:00
alpaca-tcandEugen 00392d3c63 ActiveRecord::NotFound is not defined (#1864) 2017-04-15 21:17:59 +02:00
alpaca-tcandEugen f9d7ec8971 ActiveRecord::Relation does not respond to #id (#1834) 2017-04-15 13:16:24 +02:00