Akihiko Odaki
0de82dd316
Do not filter statuses with unknown languages ( #5045 )
2017-09-22 19:33:17 +02:00
Akihiko Odaki
bb4d005a83
Introduce OStatus::TagManager ( #5008 )
2017-09-19 18:08:08 +02:00
Akihiko Odaki
813e650729
Remove ubuntu-toolchain-r-test ( #5005 )
2017-09-19 05:06:27 +02:00
Akihiko Odaki
9619b7f727
Use Account.local.sum(statuses_count) instead of Status.local.count ( #4996 )
...
It is faster.
2017-09-18 14:59:57 +02:00
Akihiko Odaki
198a9a4fa4
Remove local_only scope in Status ( #4977 )
2017-09-17 05:29:43 +02:00
Akihiko Odaki
48d77ea1eb
Fix filterable_languages method of SettingsHelper ( #4966 )
2017-09-16 14:59:41 +02:00
Akihiko Odaki
a789315361
Use next instead of return in task ( #4787 )
2017-09-03 12:39:39 +02:00
Akihiko Odaki
249bdc169c
Explicitly define attached file of DeprecatedPreviewCard ( #4786 )
...
The path template of the attached files must explicitly be defined because
it is contradicting to the name of the class.
2017-09-03 07:58:58 +02:00
Akihiko Odaki
69957ed10a
Fix the usages of Detect Passive Events ( #4749 )
2017-08-31 11:20:54 +02:00
Akihiko Odaki
9958eba356
Do not scroll the columns area due to redirection ( #4541 )
...
Commit 9d1f8b9d6a scrolls the columns area
when the route changes since the user is likely to want to see the
rightmost column in such cases.
However, redirection is automatic and does not indicate users' intension.
Do not scroll the columns area due to one.
2017-08-29 14:16:21 +02:00
Akihiko Odaki
9d1f8b9d6a
Scroll columns area to right when children property is changed ( #4517 )
...
The feature to pin column could hide the rightmost column, which is
specified with children property of ColumnsArea.
The user is likely to see the column when the property changed, so scroll
the area in such cases.
2017-08-04 18:57:46 +02:00
Akihiko Odaki
0f92119ceb
Cover Api::V1:FavouritesController more ( #4409 )
2017-07-28 04:37:44 +02:00
Akihiko Odaki
4f0b638cda
Introduce access token fabricators ( #4401 )
2017-07-27 15:16:07 +02:00
Akihiko Odaki
bdf573d140
Remove redundant fabrication in the spec for Api::V1::FavouritesController ( #4391 )
2017-07-27 15:13:10 +02:00
Akihiko Odaki
7bf0afb1dc
Add index favourites on account_id and id ( #4360 )
2017-07-26 03:35:25 +02:00
Akihiko Odaki
a6ea7e282f
Merge queries in Api::V1::FavouritesController ( #4359 )
2017-07-25 16:01:03 +02:00
Akihiko Odaki
f0d6550f16
Fix logging in ProcessFeedService ( #4270 )
2017-07-19 16:02:03 +02:00
Akihiko Odaki
89b988cab5
Introduce Ostatus name space ( #4164 )
...
* Wrap methods of ProcessFeedService::ProcessEntry in classes
This is a change same with 425acecfdb , except
that it has the following changes:
* Revert irrelevant change in find_or_create_conversation
* Fix error handling for RemoteActivity
* Introduce Ostatus name space
2017-07-18 16:39:47 +02:00
Akihiko Odaki
b11ac88692
Require any modules after loading polyfill in entry points ( #4231 )
...
app/javascript/mastodon/main.js delayed the execution of modules,
but other entry points didn't. That leads to failure in executing
modules, which requires those polyfills.
Strictly enforce the rule to require any modules after loading
polyfill in entry points.
2017-07-18 00:19:02 +02:00
Akihiko Odaki
7f35947d8e
Improve a query in WebPushNotificationWorker ( #4234 )
2017-07-17 11:03:48 +02:00
Akihiko Odaki
68941d4dfa
Use update method to update session in WebPushNotificationWorker ( #4235 )
2017-07-17 11:03:42 +02:00
Akihiko Odaki
b15f790221
Require images in common.js ( #4232 )
2017-07-17 10:23:28 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
8784bd79d0
Require stylesheets in common.js ( #4152 )
...
Require stylesheets in common.js because stylesheets are shared by the
entry points.
2017-07-11 15:15:42 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
425acecfdb
Wrap methods of ProcessFeedService::ProcessEntry in classes ( #4151 )
...
ProcessFeedService::ProcessEntry had many methods, so wrap them in classes
representing activities.
2017-07-11 13:37:05 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
29f314a502
Remove redundant inclusion ( #4150 )
2017-07-11 11:55:48 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
7bacdd718a
Fix PrecomputeFeedService for filtered statuses ( #4148 )
2017-07-11 01:00:01 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
2083000027
Set default From address in config ( #3756 )
...
The old implementation sets default From address in mailers. It sets
the address from SMTP_FROM_ADDRESS, or notifications@localhost. The
behavior is occasionally undesired results.
In production environment, notifications@localhost is likely to be
incorrect.
In testing environment, the email address should not be varied by a
environment variable.
After appling this change,
In production environment, it will throw an exception when launching
Mastodon.
In testing environment, the address will be fixed with
notifications@localhost.
2017-07-07 00:12:12 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
a37cf9548c
Explicitly require MIME::Types ( #4083 )
2017-07-05 23:58:03 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
f85dbe83c8
Remove sort in Feed ( #4050 )
...
In from_redis method, statuses retrieved from the database was mapped to
the IDs retrieved from Redis. It was equivalent to order from high to low
because those IDs are sorted in the same order.
Statuses are ordered with the ID by default, so we do not have to reorder.
Sorting statuses in the database is even faster since the IDs are indexed
with B-tree.
2017-07-03 13:17:27 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
7362469d89
Do not raise an error if PrecomputeFeed could not find any status ( #4015 )
2017-06-30 13:39:42 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
0a53ca444a
Cover Admin::AccountsController more ( #3327 )
2017-06-29 01:43:10 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
f79c10162e
Use multiple pairs for zadd in PrecomputeFeedService ( #3990 )
2017-06-29 01:25:31 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
60b2b56d38
Reduce number of commands in FeedManager#trim ( #3989 )
2017-06-29 01:17:26 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
7d8e3721ae
Overwrite old statuses with reblogs in PrecomputeFeedService ( #3984 )
2017-06-28 14:50:23 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
67243bda31
Cover Auth::RegistrationsController more ( #3353 )
2017-06-25 21:42:55 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
8f991831b8
Cover Admin::DomainBlocksController more ( #3329 )
...
Also domain_block fabricator now sets unique domains
2017-06-25 21:42:36 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
6f34a6a77f
Add index statuses on account_id and id ( #3895 )
2017-06-23 17:46:00 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
e27f792c24
Some minor change and spec for Account ( #3813 )
...
* Introduce domains method to Account relation
Account had followers_domains method, which was excessively specific.
Let relation of Account have domains method instead.
* Move follow_mapping in Account to AccountInteractions
* Introduce shared examples for AccountAvatar inclusion
* Cover Account more
2017-06-22 18:34:27 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
bab5a18232
Filter direct statuses in Status.as_home_timeline ( #3842 )
...
The classes using Status.as_home_timeline, namely Feed and
PrecomputeFeedService are expected to filter direct statuses as
FanOutWriteService does, but their filtering were incomplete or missing.
This commit solves the problem by filtering direct statuses in
as_home_timeline as the other similar methods such as as_public_timeline
does.
2017-06-20 20:41:23 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
356df7ae6b
Update fabricator for MediaAttachment to attach a file according to type ( #3862 )
...
This fixes a random spec failures since commit
d55f207274 .
2017-06-20 20:40:45 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
3d13f6ea0c
Cover Block more ( #3837 )
2017-06-19 11:31:37 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
6eefccdacc
Cover DomainBlock more ( #3838 )
2017-06-19 11:31:27 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
d55f207274
Cover Export more ( #3840 )
2017-06-19 11:30:27 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
05e4728de7
Cover Favourite more ( #3841 )
2017-06-19 01:38:50 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
b51945f096
Spec AccountDomainBlock ( #3816 )
2017-06-18 02:59:49 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
74d10b9b9d
Spec UserMailer ( #3757 )
2017-06-17 01:15:00 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
f596a413ef
Localize date in digest and cover NotificationMailer more ( #3694 )
...
* Localize date in digest
* Cover NotificationMailer more
2017-06-11 12:04:35 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
4919b89ab8
Improve default language decision and spec ( #3351 )
...
* Improve default language decision
This change allows to takes account of accepted language determined by
the user agent even if the custom default locale of the instance is
configured.
* Cover Localized more
* Fix code style
2017-06-10 09:44:02 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
defe4f9bc3
Cover WebfingerResource more ( #3560 )
2017-06-04 17:13:37 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
42844df966
Spec ScopedSettings ( #3559 )
2017-06-04 17:07:39 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
e07b57852e
Remove some code in TagManager and spec ( #3547 )
...
* Do not fall back to StreamEntry if object_type is unavailable in TagManager
Since 6d6a429af8 , when Status, the only model
with stream_entry, and StreamEntry got its own logic in uri_for and
url_for, the purpose of the fallbacks to activity_type of StreamEntry
became unclear.
This commit removes the fallbacks. When adding another model with
stream_entry in future, consider to update uri_for and url_for.
* Cover TagManager more
2017-06-04 16:14:25 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
02a0fd5b64
Spec InlineRablScope ( #3542 )
2017-06-04 15:00:08 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
6505a42be0
Spec HashObject ( #3544 )
2017-06-04 14:59:52 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
e674608d10
A minor change for ProviderDiscovery and spec ( #3543 )
...
* Do not default the format in ProviderDiscovery
The format should be determined when discovering, as it is in the current
implementation, and it is a flaw if it is not determined.
* Spec ProviderDiscovery
2017-06-04 14:59:40 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
c7af8cbc90
Remove some arguments of Formatter.instance.format and spec ( #3541 )
...
* Remove some arguments of Formatter.instance.format
* Improve spec for Formatter
2017-06-04 14:58:57 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
9475fbae78
Spec Extractor ( #3540 )
2017-06-04 14:57:02 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
00e61d6807
Spec action verification of StreamEntryFinder ( #3549 )
2017-06-04 14:56:31 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
19084d3c6c
Remove Targetable ( #3548 )
2017-06-04 14:56:10 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
ce7c0def88
Remove redundant code in AtomSerializer and spec ( #3528 )
...
* Remove redundant status.reply? in AtomSerializer#object
* Cover AtomSerializer more
2017-06-03 20:51:08 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
10768aa204
Spec response for forgery ( #3248 )
...
Remove protect_from_forgery in ApiController, which is disabled by the
following skip_before_action, as well.
2017-06-01 20:56:55 +02:00
Akihiko Odaki (@fn_aki@pawoo.net)
e98559c3ff
Resolve custom application stylesheet with Webpack ( #3373 )
...
This implementation is a bit smaller and still has the following benefits:
* No need of app/javascript/packs/custom.js
For custom stylesheet, it typically has only
"require('../styles/custom.scss')" and is redundant.
* No need to extract vendor stylesheet to another asset
Extracting vendor stylesheet could be forgotten by developers who do not
use custom stylesheet.
2017-06-01 20:56:32 +02:00
Akihiko Odaki
7db98aa70e
Refactor User and spec ( #3431 )
...
* Protect send_devise_notification of User
* Improve spec for User
2017-05-30 15:28:56 +02:00
Akihiko Odaki
76fa9d2488
Use around hook to restore context in InstancePresenter spec ( #3430 )
2017-05-30 09:03:35 -04:00
Akihiko Odaki
dfc43a6d3d
Use around hook to restore context in InstanceHelper spec ( #3429 )
2017-05-30 06:32:33 -04:00
Akihiko Odaki
67bc58dd60
Use around hook to restore context in Admin::SettingsController spec ( #3428 )
2017-05-30 06:32:09 -04:00
Akihiko Odaki
2d39560dc1
Use around hook to restore context in ApplicationHelper spec ( #3432 )
2017-05-30 06:29:48 -04:00
Akihiko Odaki
922fb74197
Remove methods from ObfuscateFilename and spec ( #3347 )
...
* Remove methods from ObfuscateFilename
* Spec ObfuscateFilename
2017-05-29 18:14:16 +02:00
Akihiko Odaki
7bf2d6cb06
Spec Auth::ConfirmationsController ( #3348 )
2017-05-29 18:13:11 +02:00
Akihiko Odaki
11e5c965c3
Spec AccountControllerConcern ( #3349 )
2017-05-29 18:12:54 +02:00
Akihiko Odaki
34157d118c
Cover Admin::ReportsController more ( #3346 )
2017-05-29 18:12:34 +02:00
Akihiko Odaki
7b92950f1c
Cover InstancesController more ( #3342 )
2017-05-29 18:12:17 +02:00
Akihiko Odaki
97d7028c31
Cover Admin::SuspensionsController more ( #3350 )
2017-05-29 18:11:16 +02:00
Akihiko Odaki
a7f2961621
Spec Auth::PasswordsController ( #3352 )
2017-05-29 18:10:50 +02:00
Akihiko Odaki
00dda99789
Spec Admin::ResetsController calls send_reset_password_instructions ( #3354 )
2017-05-29 18:09:17 +02:00
Akihiko Odaki
2e27ce3b61
Spec #destroy feature of Admin::TwoFactorAuthenticationsController ( #3355 )
2017-05-29 18:08:58 +02:00
Akihiko Odaki
2c10c5a069
Coever Admin::SilencesController more ( #3356 )
2017-05-29 18:08:42 +02:00
Akihiko Odaki
bd4dd4c4a0
Cover Settings::ExportsController more ( #3358 )
2017-05-29 18:08:26 +02:00
Akihiko Odaki
7d33b60f3f
Cover Oauth::AuthorizedApplicationsController ( #3359 )
2017-05-29 18:08:05 +02:00
Akihiko Odaki
aecce5694b
Cover Oauth::AuthorizationsController more ( #3361 )
2017-05-29 18:07:39 +02:00
Akihiko Odaki
0e4ca51951
Cover Settings::TwoFactorAuthenticationsController more ( #3376 )
2017-05-29 18:07:07 +02:00
Akihiko Odaki
dde043f6cd
Cover WellKnown::HostMetaController more ( #3382 )
2017-05-29 18:05:30 +02:00
Akihiko Odaki
c778a60e4f
Cover Settings::TwoFactorAuthentication::RecoveryCodesController more ( #3383 )
2017-05-29 18:05:20 +02:00
Akihiko Odaki
c347327d54
Spec Settings::Exports ( #3384 )
...
* Spec output of Settings::Exports::BlockedAccountsController
* Spec output of Settings::Exports::FollowingAccountsController
* Spec output of Settings::Exports::MutedAccountsController
* Spec Settings::Exports::BaseController
This commit removes duplicate specs in classes inheriting
Settings::Exports::BaseController as well.
2017-05-29 18:05:01 +02:00
Akihiko Odaki
fd328cf6e8
Cover WellKnown::WebfingerController more ( #3385 )
2017-05-29 18:04:37 +02:00
Akihiko Odaki
7b473d7514
Cover Settings::TwoFactorAuthentication::ConfirmationsController more ( #3386 )
2017-05-29 18:04:00 +02:00
Akihiko Odaki
dff576b75d
Cover ApplicationHelper more ( #3412 )
2017-05-29 18:03:37 +02:00
Akihiko Odaki
52ae83d008
Spec Activitystreams2BuilderHelper ( #3413 )
2017-05-29 18:03:15 +02:00
Akihiko Odaki
5aacd9d4c7
Spec FlashesHelper ( #3414 )
2017-05-29 18:03:02 +02:00
Akihiko Odaki
d24d3fa283
Spec HomeHelper ( #3415 )
2017-05-29 18:02:44 +02:00
Akihiko Odaki
c8a226f61c
Spec HttpHelper ( #3416 )
2017-05-29 18:02:32 +02:00
Akihiko Odaki
7a281c477a
Cover Admin::PubSubHubHubController more ( #3343 )
2017-05-29 18:01:37 +02:00
Akihiko Odaki
189a06d2a2
Fix Webpack Bundle Analyzer output for Webpacker ( #3374 )
...
Webpacker failed to parse output of Webpack when a module requires
non-existent module or has similar errors. This commit fixes the bug.
2017-05-28 16:26:16 +02:00
Akihiko Odaki
860e257a68
Remove redundant call of recent scope in AccountsController ( #3330 )
...
recent is included in paginate_by_max_id.
2017-05-26 16:35:25 +02:00
Akihiko Odaki
019f3377bb
Spec Admin::BaseController ( #3328 )
2017-05-26 14:13:26 +02:00
Akihiko Odaki
a8736aab7a
Cover TagsController more ( #3306 )
2017-05-25 16:07:38 +02:00
Akihiko Odaki
5d9f479538
Cover HomeController more ( #3258 )
2017-05-23 23:37:24 +02:00
Akihiko Odaki
152b4d54e8
Cover StatusesController more ( #3259 )
2017-05-23 16:34:28 +02:00
Akihiko Odaki
ea2ef16ea4
Cover StreamEntriesController more and remove redundant instructions ( #3257 )
...
* Cover StreamEntriesController more
* Remove redundant instructions in StreamEntriesController
2017-05-23 15:04:23 +02:00
Akihiko Odaki
1d3e0a5060
Spec AuthorizeFollowsController assigns @account ( #3246 )
...
@account is used by the view.
2017-05-23 13:12:45 +02:00
Akihiko Odaki
bf575a1f5e
Introduce recent to Follow ( #3247 )
...
Introduce recent to Follow, as Account and other models have.
This change also adds specs for the scope and the dependents.
2017-05-23 13:12:19 +02:00