In progress of adding revision views & making entity displays nicer

modules/opencase_entities/src/Entity/OCActor.php

@@ -247,11 +247,6 @@ class OCActor extends RevisionableContentEntityBase implements OCActorInterface
         'text_processing' => 0,
       ])
       ->setDefaultValue('')
-      ->setDisplayOptions('view', [
-        'label' => 'above',
-        'type' => 'string',
-        'weight' => -9,
-      ])
       ->setDisplayOptions('form', [
         'type' => 'string_textfield',
         'weight' => -9,
@@ -267,11 +262,6 @@ class OCActor extends RevisionableContentEntityBase implements OCActorInterface
         'text_processing' => 0,
       ])
       ->setDefaultValue('')
-      ->setDisplayOptions('view', [
-        'label' => 'above',
-        'type' => 'string',
-        'weight' => -8,
-      ])
       ->setDisplayOptions('form', [
         'type' => 'string_textfield',
         'weight' => -8,
@@ -287,11 +277,6 @@ class OCActor extends RevisionableContentEntityBase implements OCActorInterface
         'text_processing' => 0,
       ])
       ->setDefaultValue('')
-      ->setDisplayOptions('view', [
-        'label' => 'above',
-        'type' => 'string',
-        'weight' => -7,
-      ])
       ->setDisplayOptions('form', [
         'type' => 'string_textfield',
         'weight' => -7,
@@ -313,6 +298,7 @@ class OCActor extends RevisionableContentEntityBase implements OCActorInterface
     // so it is not exposed to user configuration. 
     $fields['email'] = BaseFieldDefinition::create('string')
       ->setLabel(t('Email Address'))
+      ->setRevisionable(TRUE)
       ->setSettings(array(
         'default_value' => '',
         'max_length' => 30,
@@ -329,6 +315,7 @@ class OCActor extends RevisionableContentEntityBase implements OCActorInterface
       ));
     $fields['phone'] = BaseFieldDefinition::create('string')
       ->setLabel(t('Main Phone Number'))
+      ->setRevisionable(TRUE)
       ->setSettings(array(
         'default_value' => '',
         'max_length' => 20,
@@ -344,6 +331,7 @@ class OCActor extends RevisionableContentEntityBase implements OCActorInterface
         'weight' => -4,
       ));
     $fields['phone2'] = BaseFieldDefinition::create('string')
+      ->setRevisionable(TRUE)
       ->setLabel(t('Alternative Phone Number'))
       ->setSettings(array(
         'default_value' => '',
@@ -360,6 +348,7 @@ class OCActor extends RevisionableContentEntityBase implements OCActorInterface
         'weight' => -3,
       ));
     $fields['postal_address'] = BaseFieldDefinition::create('string_long')
+      ->setRevisionable(TRUE)
       ->setLabel(t('Postal Address'))
       ->setDescription(t('Full address, apart from post code.'))
       ->setSettings(array(
@@ -377,6 +366,7 @@ class OCActor extends RevisionableContentEntityBase implements OCActorInterface
         'weight' => -2,
       ));
     $fields['post_code'] = BaseFieldDefinition::create('string')
+      ->setRevisionable(TRUE)
       ->setLabel(t('Post Code'))
       ->setSettings(array(
         'default_value' => '',

modules/opencase_entities/src/Entity/OCCase.php

@@ -222,16 +222,15 @@ class OCCase extends RevisionableContentEntityBase implements OCCaseInterface {
       ->setDefaultValue(TRUE);
 
     $fields['user_id'] = BaseFieldDefinition::create('entity_reference')
-      ->setLabel(t('Entered by'))
+      ->setLabel(t('Created by'))
       ->setDescription(t('The user ID of author of the Case entity.'))
       ->setRevisionable(TRUE)
       ->setSetting('target_type', 'user')
       ->setSetting('handler', 'default')
       ->setTranslatable(TRUE)
       ->setDisplayOptions('view', [
-        'label' => 'inline',
+        'label' => 'above',
         'type' => 'author',
-        'weight' => -4,
       ]);
     $fields['name'] = BaseFieldDefinition::create('string')
       ->setLabel(t('Case Title'))
@@ -245,7 +244,6 @@ class OCCase extends RevisionableContentEntityBase implements OCCaseInterface {
       ->setDisplayOptions('view', [
         'label' => 'hidden',
         'type' => 'string',
-        'weight' => -3,
       ])
       ->setDisplayOptions('form', [
         'type' => 'string_textfield',
@@ -261,6 +259,7 @@ class OCCase extends RevisionableContentEntityBase implements OCCaseInterface {
       ->setTranslatable(TRUE)
       ->setCardinality(-1)
       ->setDisplayOptions('form', [
+        'label' => 'above',
         'type' => 'entity_reference_autocomplete',
         'weight' => -2,
         'settings' => [
@@ -272,7 +271,6 @@ class OCCase extends RevisionableContentEntityBase implements OCCaseInterface {
       ])
       ->setDisplayOptions('view', [
         'label' => 'above',
-        'weight' => -2
       ])
       ->setDefaultValueCallback('Drupal\opencase_entities\Entity\OCCase::defaultVal')
       ->setRequired(TRUE);
@@ -295,17 +293,30 @@ class OCCase extends RevisionableContentEntityBase implements OCCaseInterface {
       ])
       ->setDisplayOptions('view', [
         'label' => 'above',
-        'weight' => -1,
         'settings' => ['use_description_as_link_text' => 'true']
       ]);
 
     $fields['created'] = BaseFieldDefinition::create('created')
-      ->setLabel(t('Created'))
-      ->setDescription(t('The time that the entity was created.'));
+      ->setLabel(t('Created on'))
+      ->setDescription(t('When the case was created.'))
+      ->setDisplayOptions('view', [
+        'type' => "datetime_default",
+        'label' => 'above',
+        'settings' => [
+          'date_format' => 'short'
+        ]
+      ]);
 
     $fields['changed'] = BaseFieldDefinition::create('changed')
-      ->setLabel(t('Changed'))
-      ->setDescription(t('The time that the entity was last edited.'));
+      ->setLabel(t('Last updated'))
+      ->setDescription(t('When the case was last edited.'))
+      ->setDisplayOptions('view', [
+        'type' => "datetime_custom",
+        'label' => 'above',
+        'settings' => [
+          'date_format' => 'm/d/Y'
+        ]
+      ]);
 
     $fields['revision_translation_affected'] = BaseFieldDefinition::create('boolean')
       ->setLabel(t('Revision translation affected'))

modules/opencase_entities/src/Form/OCActorForm.php

@@ -38,18 +38,11 @@ class OCActorForm extends ContentEntityForm {
    */
   public function save(array $form, FormStateInterface $form_state) {
     $entity = $this->entity;
-
-    // Save as a new revision if requested to do so.
-    if (!$form_state->isValueEmpty('new_revision') && $form_state->getValue('new_revision') != FALSE) {
-      $entity->setNewRevision();
-
-      // If a new revision is created, save the current user as revision author.
-      $entity->setRevisionCreationTime(REQUEST_TIME);
-      $entity->setRevisionUserId(\Drupal::currentUser()->id());
-    }
-    else {
-      $entity->setNewRevision(FALSE);
-    }
+    // Always make a new revision for a person. They are not changed often and people are likely to
+    // want to know what has happened to them over time.
+    $entity->setNewRevision();
+    $entity->setRevisionCreationTime(REQUEST_TIME);
+    $entity->setRevisionUserId(\Drupal::currentUser()->id());
 
     $status = parent::save($form, $form_state);