Added access control for viewing activity

Can only view activity if involved in the case.
This commit is contained in:
naomi
2018-07-19 15:10:02 +02:00
parent d2bd27c960
commit ec99009f16
3 changed files with 18 additions and 8 deletions

View File

@ -24,11 +24,15 @@ class OCActivityAccessControlHandler extends EntityAccessControlHandler {
if (!$entity->isPublished()) {
return AccessResult::allowedIfHasPermission($account, 'view unpublished activity entities');
}
return AccessResult::allowedIfHasPermission($account, 'view published activity entities');
case 'update':
return AccessResult::allowedIfHasPermission($account, 'edit activity entities');
return AccessResult::allowedIf(
$account->hasPermission('view published case entities') // activity permissions are inherited from case
|| CaseInvolvement::userIsInvolved_activity($account, $entity)
);
case 'update': // allowed only if a) they can see the case the activity is on and b) they can edit cases
return AccessResult::allowedIf(
$account->hasPermission('edit case entities')
&& ($account->hasPermission('view published case entities') || CaseInvolvement::userIsInvolved_activity($account, $entity))
);
case 'delete':
return AccessResult::allowedIfHasPermission($account, 'delete activity entities');
}