coop-cloud/abra
coop-cloud
/
abra
Archived
7
0
Fork 2
Code Issues 21 Pull Requests Releases Activity

<domain> → <app>, APP → TYPE #60

Merged
decentral1se merged 3 commits from domain_to_app into main 2020-12-30 21:22:12 +00:00
Conversation 1 Commits 3 Files Changed 3 +150 -136
3wordchant commented 2020-12-30 19:27:58 +00:00
Owner
Copy Link

Closes #47

To test, edit a stack's .env.sample file to change APP to TYPE, and if you're testing an existing app then edit that app's .env file the same way.

I didn't rename STACK_NAME yet pending deciding whether to keep the feature to over-ride it.

Closes #47 To test, edit a stack's `.env.sample` file to change `APP` to `TYPE`, and if you're testing an existing app then edit that app's `.env` file the same way. I didn't rename `STACK_NAME` yet pending deciding whether to keep the feature to over-ride it.
3wordchant added 2 commits 2020-12-30 19:27:59 +00:00
continuous-integration/drone/pr Build is failing Details
6761574d74 Add "app name" concept, and rename APP → TYPE 
Ref #47
3wordchant added 1 commit 2020-12-30 19:57:48 +00:00
continuous-integration/drone/pr Build is failing Details
bbaacb7b9f Update tests for app-name
3wordchant requested review from decentral1se 2020-12-30 20:02:45 +00:00
3wordchant commented 2020-12-30 20:02:49 +00:00
Author
Owner
Copy Link

Oh and tests are failing because coop-cloud/traefik isn't updated for the APP → TYPE switch yet, OK to do that after we merge this?

Oh and tests are failing because coop-cloud/traefik isn't updated for the `APP` → `TYPE` switch yet, OK to do that after we merge this?
decentral1se merged commit 15f0233351 into main 2020-12-30 21:22:12 +00:00
decentral1se deleted branch domain_to_app 2020-12-30 21:22:21 +00:00
decentral1se approved these changes 2020-12-30 21:23:05 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
decentral1se
Labels
Clear labels   
breaking-change

Anything that breaks the existing API

  
bug

Something is not working

  
CI/CD

Anything to do with testing and infra

  
design

Anything to with UX of this tool

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
plugin

Related to the plugin architecture

  
question

More information is needed

  
secrets

Everything to do with docker secrets

  
shell-completion

To do with shell completion

  
versioning

All the things to do with versioning apps

  
wontfix

This won't be fixed

No Label
breaking-change
bug
CI/CD
design
documentation
duplicate
enhancement
help wanted
invalid
plugin
question
secrets
shell-completion
versioning
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coop-cloud/abra#60
No description provided.
Delete Branch "domain_to_app"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?