recipe-maintainers/cc-ci
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

review(2): F2-14a corrections — install_steps DELETED (not no-op); env-interp-impossible is documented (abra FATA start_period format, lasuite-drive precedent) → likely justifies literal bump pending my abra re-check at claim; VETO stands

Browse Source
This commit is contained in:
autonomic-bot
2026-05-30 16:45:50 +01:00
parent c8f5912c00
commit 70a8e72a0e
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
machine-docs/REVIEW-2.md
View File

@ -2205,3 +2205,19 @@ before closing F2-14a / granting the claim:
literal-bump recipe PR head (deploy-count=1, P4 non-vacuous, ≥2 real P3, clean teardown) + the literal-bump
deviation is either justified (env-interp proven impossible) or converted to the env-var form. ghost/mumble
F2-14b/c still OPEN. VETO on DONE stands.
## F2-14a — two corrections to the entry above @2026-05-30T15:45:49Z (re-read; channel had garbled my draft)
1. **install_steps.sh was DELETED, not "no-op exit 0".** Re-verified: tests/discourse/install_steps.sh
does not exist (the whole discourse overlay wiring is gone: overlay file + COMPOSE_FILE + install_steps).
Cleaner than I stated — full removal, no dangling hook.
2. **Open-question-1 (is env-interp actually impossible?) is now substantially ANSWERED by the recipe_meta
comment** (which I read first-hand): abra REJECTS `start_period` env-interpolation —
`FATA ...Does not match format 'duration'` for BOTH `${VAR}` and quoted `"${VAR:-5m}"`, because abra
validates the literal compose duration BEFORE env substitution; no catalogue recipe env-interpolates
start_period. If accurate, that makes the literal recipe-PR bump the §9-compliant path (env var is
genuinely unavailable for THIS field), with the lasuite-drive collabora start_period recipe-PR as
precedent + a DECISIONS 2026-05-30 entry. I have NOT independently reproduced the abra FATA yet — I'll
confirm it (or the DECISIONS note) at claim; if it holds, open-question-1 resolves in the Builder's favor
and only open-question-2 remains (is a 5m→20m default bump acceptable upstream — defensible as grace-only).
So F2-14a is close: overlay gone ✓, fix-form likely justified (pending my abra re-check), needs the
green maximal-subset run + DECISIONS confirm to close. VETO on DONE still stands (ghost+mumble open).